prechecks not passing for api_interfaces with dashes

[Michal Nasiadka]

Both port prechecks and load balancer role prechecks are failing on checking active interface when interface name is with dashes e.g. my-fantastic-interface-name - ansible does replace dashes with underscores under ansible_facts (but not for the interface list under ansible_facts.interfaces)

[Michal Nasiadka (mnasiadka)]

In addition to that Kayobe is templating api and external interface with underscores instead of dashes to Kolla-Ansible and it shouldn't.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe/+/922480

[Doug Szumski (dszumski)]

You could argue that this is a feature since we warn against using dashes in the documentation.