redundant copying of config files in grafana role

Bug #2067999 reported by Jan Horstmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
Unassigned

Bug Description

Some custom grafana configuration files are copied by both task `Copying over extra configuration file` as well as individual tasks later on.
While this does not pose any problem it is still redundant.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)
Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/921096
Committed: https://opendev.org/openstack/kolla-ansible/commit/4178f02e2b549a6e5afd81cdb97086738be20b88
Submitter: "Zuul (22348)"
Branch: master

commit 4178f02e2b549a6e5afd81cdb97086738be20b88
Author: Jan Horstmann <email address hidden>
Date: Wed May 15 12:00:32 2024 +0200

    Fix redundant extra config files in grafana role

    Task `Check if extra configuration file exists` picks up all files in
    `{{ node_custom_config }}/grafana` including those that get handled
    specially later on.
    While `prometheus.yml` and `provisioning.yml` are best excluded from
    extra config , because their treatment requires more than just copying,
    `grafana_home_dashboard.json` may simply be treated as extra config,
    which saves the execution of two additional tasks.

    Closes-Bug: 2067999

    Change-Id: I7bce1fe3d0a96816f1782107b202d6dac7d1291d
    Signed-off-by: Jan Horstmann <email address hidden>

Changed in kolla-ansible:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.