Software CLI upload command failed when using external token and insecure option

Bug #2067293 reported by Joseph Vazhappilly
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Joseph Vazhappilly

Bug Description

Brief Description
-----------------
HTTPClient of software client failed to upload file/s when using insecure option

Severity
--------
Minor

Steps to Reproduce
------------------
Execute command: software --insecure --os-auth-token=$TOKEN --software-url=$URL upload-dir <dir>

Expected Behavior
------------------
Files should be successfully uploaded

Actual Behavior
----------------
Upload command failed

Reproducibility
---------------
100%

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to update (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/920553

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to update (master)

Reviewed: https://review.opendev.org/c/starlingx/update/+/920553
Committed: https://opendev.org/starlingx/update/commit/b65c0003ef36b6b603a306b22fe2cbc209ef538b
Submitter: "Zuul (22348)"
Branch: master

commit b65c0003ef36b6b603a306b22fe2cbc209ef538b
Author: Joseph Vazhappilly <email address hidden>
Date: Mon May 27 11:23:07 2024 -0400

    Fix software cli upload command with HTTPClient

    Software cli uses HTTPClient when endpoint and token are provided
    in the command line. HTTPClient fails when doing upload file/s
    as it is not using passed token and insecure option.

    This change updates HTTPClient to use token and insecure option
    when using upload/upload-dir commands and remove some unused
    functions from the client.

    Test Plan:
    PASS: Verify upload & upload-dir commands using software cli
              (Eg. software --os-auth-token=$TOKEN \
               --software-url=$URL upload-dir <dir>)
    PASS: Verify upload & upload-dir commands using insecure cli
              (Eg. software --insecure --os-auth-token=$TOKEN \
               --software-url=$URL upload-dir <dir>)
    PASS: Verify ca-file, cert-file, key-file options for upload
              (Eg. software --ca-file=<ca file> \
               --key-file=<key file> --cert-file=<cert file> \
               --os-auth-token=$TOKEN --software-url=$URL \
               upload-dir <upload dir>)

    Closes-Bug: 2067293

    Story: 2010676
    Task: 50197

    Change-Id: I32264cfd2178d8b75b02d4d1703c5e36c94828d3
    Signed-off-by: Joseph Vazhappilly <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.10.0 stx.update
Changed in starlingx:
assignee: nobody → Joseph Vazhappilly (jvazhapp)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.