Ubuntu Noble lacks of CRIU package

[Aleksandr Mikhalitsyn]

It looks like because of build failures on Noble toolchain:
https://launchpad.net/ubuntu/noble/+source/criu/+builds

precisely the same version was building just fine on Mantic.

$ rmadison criu -u ubuntu
 criu | 2.0-2ubuntu3 | xenial/universe | source, amd64, armhf, ppc64el
 criu | 2.6-1ubuntu1~ubuntu16.04.2 | xenial-updates/universe | source, amd64, armhf, ppc64el
 criu | 3.6-2 | bionic/universe | source, amd64, arm64, armhf, ppc64el, s390x
 criu | 3.16.1-2 | jammy/universe | source, amd64, arm64, armhf, ppc64el, s390x
 criu | 3.17.1-3 | mantic/universe | source, amd64, arm64, armhf, ppc64el, s390x

[Aleksandr Mikhalitsyn (mihalicyn)]

It's clearly a false-positive on GCC 13.2

Attaching a Debian diff with workaround (disable warnings and prevent compilation failures).

[Aleksandr Mikhalitsyn (mihalicyn)]

Tested with PPA and it looks like compile-time problem is fixed, but now we have the next one:
https://launchpadlibrarian.net/730889722/buildlog_ubuntu-noble-ppc64el.criu_3.17.1-3ubuntu1_BUILDING.txt.gz

mkdir -p /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu
install -m 755 lib/c/libcriu.so /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/libcriu.so.2.0
ln -fns libcriu.so.2.0 /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/libcriu.so.2
ln -fns libcriu.so.2.0 /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/libcriu.so
install -m 755 lib/c/libcriu.a /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/libcriu.a
mkdir -p /<<PKGBUILDDIR>>/debian/criu/usr/include/criu/
install -m 644 lib/c/criu.h images/rpc.proto images/rpc.pb-c.h criu/include/version.h /<<PKGBUILDDIR>>/debian/criu/usr/include/criu/
mkdir -p /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/pkgconfig
sed -e 's,@version@,3.17.1,' -e 's,@libdir@,/usr/lib/powerpc64le-linux-gnu,' -e 's,@includedir@,/usr/include/criu/,' lib/c/criu.pc.in > lib/c/criu.pc
install -m 644 lib/c/criu.pc /<<PKGBUILDDIR>>/debian/criu/usr/lib/powerpc64le-linux-gnu/pkgconfig
python3 scripts/crit-setup.py install --prefix=/<<PKGBUILDDIR>>/debian/criu/usr --record lib/.crit-setup.files
/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!
  self.initialize_options()
/usr/lib/python3/dist-packages/setuptools/_distutils/cmd.py:66: EasyInstallDeprecationWarning: easy_install command is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` and ``easy_install``.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://github.com/pypa/setuptools/issues/917 for details.
        ********************************************************************************

!!
  self.initialize_options()
TEST FAILED: /<<PKGBUILDDIR>>/debian/criu/usr/local/lib/python3.12/dist-packages/ does NOT support .pth files
bad install directory or PYTHONPATH

You are attempting to install a package to a directory that is not
on PYTHONPATH and which Python does not read ".pth" files from. The
installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /<<PKGBUILDDIR>>/debian/criu/usr/local/lib/python3.12/dist-packages/

and your PYTHONPATH environment variable currently contains:

    ''

Here are some of your options for correcting the problem:

* You can choose a different installation directory, i.e., one that is
  on PYTHONPATH or supports .pth files

* You can add the installation directory to the PYTHONPATH envi...

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "deb.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Hans Joachim Desserud (hjd)]

> It looks like because of build failures on Noble toolchain:

See also https://launchpad.net/ubuntu/+source/criu/+publishinghistory . Looks like the error message you get comment 2 is similar to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054814 reported in Debian.

[Aleksandr Mikhalitsyn (mihalicyn)]

New debdiff.

Tested with https://launchpad.net/~mihalicyn/+archive/ubuntu/criu-noble-test/+packages

[Dave Jones (waveform)]

Hi Aleksandr -- thanks for the patch. There's a few things I'd like to rectify, and a couple of questions which should probably be answered before this can be sponsored. If we're going to introduce a delta on Debian, we should ensure things are forwarded so the delta can be resolved in time. To that end, the patches should have the Origin: or Forwarded: tag so we can track what's been forwarded and where. Looking through the patches added:

d/p/criu-fix-compatibility-with-python3-12.patch:
It would be preferable to add this as the two original patches it's made of so that each patch can have a simple Origin: header indicating where it came from (no need for Fowarded: in this case). Also, Author: should be Radostin (your name goes in d/changelog as the editor of the package, but Radostin is the author of the patch).

d/p/make-disable-Wformat-truncation-warning-with-gcc-13-2.patch:
Likewise, Author: should be Radostin. I'm a little confused about the origin of this patch. The referenced bug (https://github.com/checkpoint-restore/criu/issues/2398) has quite a different resolution upstream to the content of this patch (https://github.com/checkpoint-restore/criu/pull/2413/files). I'm guessing the upstream resolution is more recent; does the patch need revising?

d/p/time-t-64bit-transition-fixes.patch:
I'm assuming the Author: tag is correct here, as there's no other origin, but there's also no Forwarded: tag. Does this patch need forwarding upstream?

Finally, d/changelog currently references noble but I *suspect* this will need to go into oracular first and then be SRU'd to noble (I've requested clarification on #ubuntu-release, but I think this is the procedure when something's been absent for more than one release).

Anyway, I'll unsubscribe ubuntu-sponsors for now, but please feel free to add this back in if these points can be addressed.