test_vif_attach_node_doesnt_exist and test_vif_detach_no_args fail when shared_physical_network is set to true

[Lukas Piwowarski]

The following two tests:
 - ironic_tempest_plugin.tests.api.admin.test_nodes.TestNodesVif.test_vif_attach_node_doesnt_exist
 - ironic_tempest_plugin.tests.api.admin.test_nodes.TestNodesVif.test_vif_detach_no_args

are failing consistently on:

Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/ironic_tempest_plugin/tests/api/admin/test_nodes.py", line 317, in setUp
    self.net = self.os_admin.networks_client.list_networks(
IndexError: list index out of range

when CONF.network.shared_physical_network is set to true. Note, that both tests pass when shared_physical_network == false.

I'm attaching log with the failure and tempest.conf.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/919544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/919544
Committed: https://opendev.org/openstack/ironic-tempest-plugin/commit/332dacdaba67add001dcec5edb06281839b57772
Submitter: "Zuul (22348)"
Branch: master

commit 332dacdaba67add001dcec5edb06281839b57772
Author: Julia Kreger <email address hidden>
Date: Mon May 13 14:09:51 2024 -0700

    Handle invalid configuration for vif test execution

    It is entirely possible to run the tempest tests without a physical
    network parameter for the compute service. Turns out the network is
    required when you use [network]shared_physical_network set to true,
    because without it we can't figure out how to attach to the network.

    So now we skip when the input configuration is such that there is
    no way for the tests to proceed.

    Closes-Bug: 2065378
    Change-Id: Ic448a1a6383c2da2567b9da2262d4572536296ed