DC SystemController bootstrap failed - "Wait for system controller database configuration to complete"

[Raphael Lima]

Brief Description
-----------------
DC SystemController bootstrap fail during bootstrap playbook, in the task: "bootstrap/persist-config : Wait for system controller database configuration to complete".

In puppet logs, we can see the error message: "Evaluation Error: Error while evaluating a Function Call, Failed to execute generator /bin/dcmanager: Execution of '/bin/dcmanager complete' returned 1: ERROR (app) This command has been deprecated. Please use 'subcloud deploy config' instead. (file: /usr/share/puppet/modules/dcmanager/manifests/init.pp, line: 125, column: 16) on node controller-0.wrs.com"

Severity
-----------------
Critical (bootstrap fails).

Steps to Reproduce
-----------------
Bootstrap DC system.

Expected Behavior
-----------------
Bootstrap should succeed.

Actual Behavior
-----------------
Bootstrap fails.

Reproducibility
-----------------
100%.

System Configuration
-----------------
DC system

Timestamp/Logs
-----------------
ansible.log:

2024-05-02 13:30:29,958 p=27763 u=sysadmin n=ansible | TASK [bootstrap/persist-config : Wait for system controller database configuration to complete] ***
2024-05-02 13:30:29,958 p=27763 u=sysadmin n=ansible | Thursday 02 May 2024  13:30:29 +0000 (0:00:00.851)       0:02:17.325 **********
2024-05-02 13:35:30,739 p=27763 u=sysadmin n=ansible | fatal: [localhost]: FAILED! => changed=false
  elapsed: 300
  msg: Timeout waiting for system controller database configuration to complete

puppet.log:

2024-05-02T13:25:51.161 Error: 2024-05-02 13:25:51 +0000 Evaluation Error: Error while evaluating a Function Call, Failed to execute generator /bin/dcmanager: Execution of '/bin/dcmanager complete' returned 1: ERROR (app) This command has been deprecated. Please use 'subcloud deploy config' instead. (file: /usr/share/puppet/modules/dcmanager/manifests/init.pp, line: 125, column: 16) on node controller-0.wrs.com

Alarms
-----------------
NA

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud-client/+/918010
Committed: https://opendev.org/starlingx/distcloud-client/commit/e55e4a5c4999186bad75491ab5be8a614d73185c
Submitter: "Zuul (22348)"
Branch: master

commit e55e4a5c4999186bad75491ab5be8a614d73185c
Author: Raphael Lima <email address hidden>
Date: Thu May 2 16:47:54 2024 -0300

    Fix dcmanager complete execution

    The implementation [1] to deprecate commands in dcmanager's client
    raised an exception when dcmanager help <command> was executed
    which happened to break the dcmanager complete command used during
    bootstrap.
    This fix solves the issue and adds the deprecation message as a
    notice in the relevant commands.

    [1]: https://review.opendev.org/c/starlingx/distcloud-client/+/917493

    Test plan:
    1. PASS: Run dcmanager help <command> displays the relevant
    deprecation message
    2. PASS: Run dcmanager <command> displays the relevant
    deprecation message and does not execute
    3. PASS: Run dcmanager complete command

    Closes-Bug: 2064677

    Change-Id: Icbe6e6f5e8145bb786d4b6aebb804416959cbb67
    Signed-off-by: Raphael Lima <email address hidden>