rocr-runtime 5.7.1-2 fails to build on armhf

[Benjamin Drung]

rocr-runtime 5.7.1-2 fails to build on armhf (with 64-bit time_t):

In file included from /<<PKGBUILDDIR>>/src/core/inc/runtime.h:62,
                 from /<<PKGBUILDDIR>>/src/core/util/lnx/os_linux.cpp:62:
/<<PKGBUILDDIR>>/src/core/inc/signal.h:155:58: error: static assertion failed: Bad SDMA time stamp alignment.
  155 | static_assert((offsetof(SharedSignal, sdma_end_ts) % 32) == 0,
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/<<PKGBUILDDIR>>/src/core/inc/signal.h:155:58: note: the comparison reduces to ‘(24 == 0)’

The struct in question:

```
struct SharedSignal {
  amd_signal_t amd_signal;
  uint64_t sdma_start_ts;
  Signal* core_signal;
  Check<0x71FCCA6A3D5D5276, true> id;
  uint8_t reserved[8];
  uint64_t sdma_end_ts;
  uint8_t reserved2[24];
```

amd_signal is aligned to 32 bytes. core_signal and id are 4 bytes on armhf but 8 bytes on amd64.

Full log: https://launchpadlibrarian.net/720487883/buildlog_ubuntu-noble-armhf.rocr-runtime_5.7.1-2_BUILDING.txt.gz

[Cory Bloor (slavik81)]

Note that no version of rocr-runtime has ever built successfully for armhf. rocr-runtime should probably be limited to amd64, arm64 and ppc64el (as those are the only architectures that have driver support from AMDGPU KFD).

I've been cautious about dropping architectures that successfully built because I cannot test them to confirm that they don't actually work. I'm not sure it's even physically possible to install an AMD GPU into an IBM System z mainframe (s390x).

However, I suppose that I could easily add `Build-Depend: architecture-is-64-bit` to d/control so that it doesn't attempt to build for armhf.

[Cory Bloor (slavik81)]

I've pushed the change to salsa, so future versions of rocr-runtime will be restricted to 64-bit architectures [1]. However, I'm not sure it's worth uploading a new version of the package just for that. I'll wait and see for a couple weeks if there are any more bugs reported before making another upload and sync request.

[1]: https://salsa.debian.org/rocm-team/rocr-runtime/-/commit/076026d43bbee7f816b81fea72f984213a9ff961

[Benjamin Drung (bdrung)]

Thanks. Using architecture-is-64-bit makes sense. You do not need to urgently upload this change since armhf has never seen a successful build. I initially falsely thought that this package was affected by the 64-bit time_t transition.