Relax Zuul shellcheck lint SC2319 overwrite return value
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
New
|
Undecided
|
Jim Gauld |
Bug Description
Brief Description
-----------------
Zuul tox job now failing for stx-puppet.
In /home/zuul/
Possible fixes:
* Modify the problematic shell code apply_network_
This open review addresses this specifically.
https:/
* Pin the shellcheck version:
passes with: shellcheck-
fails with: shellcheck-
* Relax the specific checks that are failing:
# shellcheck disable=
or, -eSC2319
Severity
--------
Critical: Prevents code submission.
Steps to Reproduce
------------------
Update stx-puppet with a patchset.
Expected Behavior
------------------
Previous codebase should pass existing linters.
Actual Behavior
----------------
Changed upstream version of shellcheck has different behavior for specific tests.
Reproducibility
---------------
100%
System Configuration
-------
gerrit review
Branch/Pull Time/Commit
-------
NA
Last Pass
---------
Recent.
Timestamp/Logs
--------------
NA
Test Activity
-------------
Development
Workaround
----------
None.
Changed in starlingx: | |
assignee: | nobody → Jim Gauld (jgauld) |
description: | updated |
Issue seems to have been fixed by: https:/ /review. opendev. org/c/starlingx /stx-puppet/ +/910257