900.002 patch alarm raised after lock/unlock

[Bala Shankar MV]

Brief Description
-----------------
In SX system, lock/unlock controller. After the host was unlocked, 900.002 alarm "Patch installation failed on the following hosts: controller-0" was raised.

Severity
--------
Major

Steps to Reproduce
------------------
Lock and unlock the controller

TC-name: wrcp/regression/mtc/test_lock_unlock_host.py::test_lock_unlock_host

Expected Behavior
------------------
lock unlock active controller. After the host was recovered, 900.002 alarm not raised.

Actual Behavior
----------------
lock unlock active controller. After the host was recovered, 900.002 alarm was raised.

Reproducibility
---------------
2/2

System Configuration
--------------------
Single node system

Lab-name: WRCP_SX_014

Branch/Pull Time/Commit
-----------------------
Project: wrcp-master-debian
Build Id: 20240303T070104Z

Last Pass
---------
20240227T070056Z

Timestamp/Logs
--------------
[sysadmin@controller-0 ~(keystone_admin)]$ fm alarm-list
+----------+----------------------------------------------------------------+-----------------+----------+---------------------+
| Alarm ID | Reason Text | Entity ID | Severity | Time Stamp |
+----------+----------------------------------------------------------------+-----------------+----------+---------------------+
| 900.002 | Patch installation failed on the following hosts: controller-0 | host=controller | major | 2024-03-06T05:15:10 |
| | | | | .540820 |
| | | | | |
+----------+----------------------------------------------------------------+-----------------+----------+---------------------+

collect log:
/folk/cgts_logs/logs/CGTS-59000/latest_logs/ALL_NODES_20240306.082206.tar

Test Activity
-------------
STX Regression

[Ghada Khalil (gkhalil)]

Setting to high priority since this is failing sanity

[Ghada Khalil (gkhalil)]

Issue appears to be intermittent as it wasn't reported in the subsequent sanity from stx.9.0, so lowering the priority
https://<email address hidden>/thread/MLA37BWGQFJVLNA5C2K42EGDT6VDGCI2/

[Bala Shankar MV (bshankar)]

Issue was reproduced in starlingx master load (https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/monolithic/20240415T235616Z/outputs/iso/starlingx-intel-x86-64-cd.iso)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/917763
Committed: https://opendev.org/starlingx/update/commit/c9d1a9f8c63a1ddea170fd2ccef576eabecda9e1
Submitter: "Zuul (22348)"
Branch: master

commit c9d1a9f8c63a1ddea170fd2ccef576eabecda9e1
Author: mmachado <email address hidden>
Date: Tue Apr 30 12:40:52 2024 -0300

    expand sw_patch config check to other deploy types

    In some cases, the sw_patch service tries to ping the management IP
    before it's configured, causing a service failure and the 900.002
    alarm to be raised.

    This commit expands a solution that has been implemented for AIO-SX
    systems to other deploy types.

    Test Plan:
    PASS: Successful AIO-SX (VDM)
    PASS: Successful AIO-DX (VDM)
    PASS: Successful DC with 1 AIO-SX subcloud (VDM)
    PASS: Apply patch before bootstrap on AIO-DX (VDM)

    Partial-bug: 2056295

    Change-Id: I6308a91c1149aca4bef78ed175f8e02d6667944e
    Signed-off-by: mmachado <email address hidden>