Fixed Fields Grid in Enhanced MARC Editor Not saving Form field when Type = m

Bug #2056204 reported by Dale Rigney
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.11
Fix Released
Medium
Unassigned

Bug Description

Tested in Evergreen 3-11-3.

When editing a MARC record with a type of m (Computer File), Evergreen will not save the Form field entry in tag 008 position 23. You should be able to enter q for Direct electronic or o for Online but it looks like Evergreen is not allowing any entry in that field for marc type of m (Computer Files). When you enter anything in the Form field you will see that entry does not populate tag 008 position 23 like it should and saving the file will remove any entry in the that field.

Revision history for this message
Galen Charlton (gmc) wrote :

Confirmed. The proximate cause is that Open-ILS/src/eg2/src/assets/js/marcrecord.js doesn't include a mapping for 008/23 to Form when the record type is COM.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the branch working/user/gmcharlt/lp2056204_computers_are_not_formless / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2056204_computers_are_not_formless

tags: added: cat-marc cataloging pullrequest
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Mike Rylander (mrylander) wrote :

I've signed off Galen's commit, and added a followup of my own to have the tag table service (used in the angular marc editor) update the in-memory fixed field position map based on the server's configuration. Branch available at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp2056204_computers_are_not_formless-signoff-dynamic

I won't be hurt if we just take Galen's commit, though. :)

Revision history for this message
Galen Charlton (gmc) wrote :

Initial testing of Mike's follow-up patch presented an error along the lines of "property '_8' not existing"; sounds like it's hitting the shoals of JavaScript not doing Perl-style autovivication.

A branch with just my patch as signed off by Mike is available here: working/user/gmcharlt/lp2056204_with_signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Galen and Mike! I pushed the first commit to rel_3_11 and above.

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 3.12.3
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.