Buttons appearing for Visibility and Name in grid column config

Bug #2056069 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

Due to an accidental duplication of the class attribute on the buttons for Visibility and Name in the grid column config modal, the contents of these two columns appear as large, unstyled gray buttons. (See screenshot.)

Branch coming up.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2056069-grid-column-config-button-styles

To test:

1. Visit any Angular grid screen and press the Settings (gear) button.
2. In the modal that appears, verify that you don't see gray buttons around the visibility badge or the column name.

tags: added: eg-grid pullrequest
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
tags: added: regression
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signoff pushed to working/user/gmcharlt/lp2056069_signoff.

For the committer: this will be needed in main and rel_3_12, but nothing earlier.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Pushed a second commit to the same branch to handle the grid action menu modal, which had the same button issue.

Apologies for crossing the streams with your signoff, Galen, and thanks for pointing this out!

Revision history for this message
Galen Charlton (gmc) wrote :

No worries! I've tested the second patch and updated my signoff branch (working/user/gmcharlt/lp2056069_signoff)

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
Galen Charlton (gmc)
tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.12.3
Revision history for this message
Bill Erickson (berick) wrote :

Thanks. Merged to 3.12 and main.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.