[ovn-octavia-provider] ovn-octavia-provider-functional-master is broken by ovn build failure

[Takashi Kajinami]

The ovn-octavia-provider-functional-master job consistently fails during set up.
The log indicates ovn build is failing.

example: https://zuul.opendev.org/t/openstack/build/65fafcb26fdb4b9b97d9ce481f70037e
```
...
gcc -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I ./lib -I ./lib -I /home/zuul/src/opendev.org/openstack/ovs/include -I /home/zuul/src/opendev.org/openstack/ovs/include -I /home/zuul/src/opendev.org/openstack/ovs/lib -I /home/zuul/src/opendev.org/openstack/ovs/lib -I /home/zuul/src/opendev.org/openstack/ovs -I /home/zuul/src/opendev.org/openstack/ovs -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool -Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare -Wshift-negative-value -Wduplicated-cond -Wshadow -Wmultistatement-macros -Wcast-align=strict -g -O2 -MT controller/physical.o -MD -MP -MF $depbase.Tpo -c -o controller/physical.o controller/physical.c &&\
mv -f $depbase.Tpo $depbase.Po
controller/ofctrl.c: In function ‘ofctrl_inject_pkt’:
controller/ofctrl.c:3048:5: error: too many arguments to function ‘flow_compose’
 3048 | flow_compose(&packet, &uflow, NULL, 64, false);
      | ^~~~~~~~~~~~
In file included from /home/zuul/src/opendev.org/openstack/ovs/lib/dp-packet.h:34,
                 from controller/ofctrl.c:21:
/home/zuul/src/opendev.org/openstack/ovs/lib/flow.h:129:6: note: declared here
  129 | void flow_compose(struct dp_packet *, const struct flow *,
      | ^~~~~~~~~~~~
make[1]: *** [Makefile:2369: controller/ofctrl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
controller/pinctrl.c: In function ‘pinctrl_ip_mcast_handle_igmp’:
controller/pinctrl.c:5488:54: error: ‘MCAST_GROUP_IGMPV1’ undeclared (first use in this function)
 5488 | port_key_data, MCAST_GROUP_IGMPV1);
      | ^~~~~~~~~~~~~~~~~~
controller/pinctrl.c:5488:54: note: each undeclared identifier is reported only once for each function it appears in
controller/pinctrl.c:5487:13: error: too many arguments to function ‘mcast_snooping_add_group4’
 5487 | mcast_snooping_add_group4(ip_ms->ms, ip4, IP_MCAST_VLAN,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from controller/ip-mcast.h:19,
                 from controller/pinctrl.c:64:
/home/zuul/src/opendev.org/openstack/ovs/lib/mcast-snooping.h:190:6: note: declared here
  190 | bool mcast_snooping_add_group4(struct mcast_snooping *ms, ovs_be32 ip4,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
controller/pinctrl.c:5493:54: error: ‘MCAST_GROUP_IGMPV2’ undeclared (first use in this function)
 5493 | port_key_data, MCAST_GROUP_IGMPV2);
      | ^~~~~~~~~~~~~~~~~~
controller/pinctrl.c:5492:13: error: too many arguments to function ‘mcast_snooping_add_group4’
 5492 | mcast_snooping_add_group4(ip_ms->ms, ip4, IP_MCAST_VLAN,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from controller/ip-mcast.h:19,
                 from controller/pinctrl.c:64:
/home/zuul/src/opendev.org/openstack/ovs/lib/mcast-snooping.h:190:6: note: declared here
  190 | bool mcast_snooping_add_group4(struct mcast_snooping *ms, ovs_be32 ip4,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:2369: controller/pinctrl.o] Error 1
make[1]: Leaving directory '/home/zuul/src/opendev.org/openstack/ovn'
make: *** [Makefile:1528: all] Error 2
```

[Bence Romsics (bence-romsics)]

Thanks for the report and the proposed fix:

https://review.opendev.org/c/openstack/ovn-octavia-provider/+/909074

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Fernando Royo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/909074
Reason: Already merged https://review.opendev.org/c/openstack/ovn-octavia-provider/+/908320, feel free reopen it if you consider necessary, thx!

[Fernando Royo (froyoredhat)]

Merged in a previous patch https://review.opendev.org/c/openstack/ovn-octavia-provider/+/908320. Thanks Takashi Kajinami!