Reconsider what gets moved when deleting a staff user

[Galen Charlton]

Currently, when deleting a staff user, anything associated with it will get moved to a target user.

However, it occurs to me that nearly all of the time that this is overkill. I think a distinction needs to be drawn between transferring ownership from the staff user to be deleted versus rewriting history.

Concretely, the various user purge and merge functions will do things like update the checkin_staff field in action.circulation. This has a couple consequences:

- It obscures the history of which staff user actually did something
- If the staff user was active Evergreen for a long time, there could be thousands of rows to be updated. One consequence of that is that deleting a staff user can time out.

I propose that we consider rethinking how we delete staff users to instead:

- lock out the old account
- transfer things where _ownership_ by the staff user matters
- leave historical data alone

[Ruth Frasur Davis (redavis)]

Adding a 'hear hear' to this. The rewriting of history has proven problematic from an admin standpoint.

[Diane Disbro (ddisbro)]

What you propose makes sense.

Query: What happens to historical data when a staff permission is changed to a patron permission? When the now patron account is deleted, there is no prompt asking where the artifacts should be sent.

[Ruth Frasur Davis (redavis)]

In Evergreen Indiana, staff accounts are never transitioned to patron accounts because of the connectors to transactions and client-side ownership. We have a profile type called StaffCard that is a borrower profile.

[Josh Stompro (u-launchpad-stompro-org)]

At LARL/NWRL we don't delete staff accounts, we just mark them as inactive.

For some accounts we just rename them for new staff for certain positions, like for catalogers and ILL Staff so the history and connections just continues on. (Mostly so some scripts that act on patron ids don't need to be updated :-) )

We don't let staff use their Evergreen staff accounts for personal use, loan rules are setup to give those checkouts a 1 day duration so that people notice when they do it by mistake. Everyone had a personal account with a barcode(if they want one), and a staff circ account with a non barcode number based username and barcode record.