Provide python perf module

Bug #2051560 reported by Lucas Kanashiro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Committed
Undecided
Unassigned
Noble
Fix Committed
Undecided
Unassigned

Bug Description

[Impact]

We need to provide the python perf module, because some applications (such as tuned) require it.

This module is implemented inside perf, provided by the kernel.

At the moment we provide a distinct perf for each kernel installed in the system. There is really no reason to do that, because perf is both backward and forward compatible, but this is a different issue and we are not going to solve it in this context and it will be addressed in a separate bug.

For now, to solve this specific issue, we need to enable the python module when we build perf (as part of the kernel build) and ship the library inside the linux-tools-<kernel_abi_version> package.

However, this brings a new problem, because we need to install the module in a standard python path (so that python applications can be able to use it in a regular way), but we need to support multiple installed versions and add some logic to transparently select the right one when a generic user-space python application uses `import perf`.

For this reason we need to provide a python wrapper module that is imported via a regular `import perf` and it transparently loads the actual python perf module, based on the kernel that is currently running.

[Test case]

Install linux-tools-<kernel_version> and run the following simple test case:

 $ python -c 'import perf; [print(c) for c in perf.cpu_map()]'

[Fix]

 - Enable the python perf module build during the regular kernel build
 - Provide a virtual `perf` python module wrapper in linux-tools-common

[Regression potential]

We are adding a new python module to linux-tools (that is something new, we don't ship any other python module), but we are not changing anything that is already provided, so the only regression that can happen is an increased size of the linux-tools package.

[Original bug report]

The tuned package has some plugins which rely on the perf python module [1], and right now they are not working because we do not have the perf python module available in Ubuntu.

Initially, this was reported in this other bug [2], but it seems the scope of that bug is bigger than what we (Server) need for tuned. So filing this new bug as requested by the Kernel team to provide just the python module.

For reference, in Fedora it's shipped in the bin:python3-perf package:

[root@f39 ~]# rpm -ql python3-perf
/usr/lib/.build-id
/usr/lib/.build-id/80
/usr/lib/.build-id/80/9022196f598cb3327545c2d497b1d9fdf55630
/usr/lib64/python3.12/site-packages/perf-0.1-py3.12.egg-info
/usr/lib64/python3.12/site-packages/perf-0.1-py3.12.egg-info/PKG-INFO
/usr/lib64/python3.12/site-packages/perf-0.1-py3.12.egg-info/SOURCES.txt
/usr/lib64/python3.12/site-packages/perf-0.1-py3.12.egg-info/dependency_links.txt
/usr/lib64/python3.12/site-packages/perf-0.1-py3.12.egg-info/top_level.txt
/usr/lib64/python3.12/site-packages/perf.cpython-312-x86_64-linux-gnu.so
/usr/share/licenses/python3-perf
/usr/share/licenses/python3-perf/COPYING

Built from their kernel-tools package[3].

[1] https://bugs.launchpad.net/ubuntu/+source/tuned/+bug/2051290
[2] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1613393
[3] https://src.fedoraproject.org/rpms/kernel-tools/blob/rawhide/f/kernel-tools.spec#_148

description: updated
Andrea Righi (arighi)
description: updated
Revision history for this message
Andrea Righi (arighi) wrote :

Patch sent to the kernel team mailing list for review: https://lists.ubuntu.com/archives/kernel-team/2024-March/149751.html

Andrea Righi (arighi)
Changed in linux (Ubuntu):
status: New → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.8.0-32.32 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-noble-linux' to 'verification-done-noble-linux'. If the problem still exists, change the tag 'verification-needed-noble-linux' to 'verification-failed-noble-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-noble-linux-v2 verification-needed-noble-linux
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Noble verification

Confirming the bug:
$ uname -a
Linux n-perf 6.8.0-31-generic #31-Ubuntu SMP PREEMPT_DYNAMIC Sat Apr 20 00:40:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

$ sudo apt install linux-tools-$(uname -r)
(...)

$ python3 -c 'import perf; [print(c) for c in perf.cpu_map()]'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'perf'

Updating to kernel in noble-proposed and rebooting:
$ uname -a
Linux n-perf 6.8.0-32-generic #32-Ubuntu SMP PREEMPT_DYNAMIC Wed May 1 15:30:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

linux-tools was also updated:
$ dpkg -l linux-tools-$(uname -r)
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-============================-============-============-========================================================
ii linux-tools-6.8.0-32-generic 6.8.0-32.32 amd64 Linux kernel version specific tools for version 6.8.0-32

The python command now works:
$ python3 -c 'import perf; [print(c) for c in perf.cpu_map()]'
0

Another verification also shows the module is now available:

$ python3 -c 'import perf; print(perf.__file__)'
/usr/lib/python3/dist-packages/linux-tools-6.8.0-32/perf.cpython-312-x86_64-linux-gnu.so

Noble verification succeeded.

tags: added: verification-done-noble-linux
removed: verification-needed-noble-linux
Changed in linux (Ubuntu Noble):
status: New → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Kernel updated have a different procedure, but I added a noble task and marked it as fix committed, since the package is in noble-proposed. I also updated the verification tag.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.