external_ids.hostname not set in Open_vSwitch table

[Michel Nederlof]

Upon startup of ovn-bgp-agent (in NB mode) it tries to find the hostname in the Open_vSwitch table, but is either has not been configured by kolla, or it is an optional field.

We've deployed ovn with kolla ansible, and it is not set.

Kolla ansible release 2023.1, ovn release 23.09

The easy solution is to fallback to the system-id (which works fine on our end)

Change request will follow.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906043

[Maximilian Sesterhenn (msnatepg)]

Hey there,

were also deploying with kolla-ansible and have faced the same issue.

We're working on changes in kolla-ansible and other projects to be able to deploy the ovn-bgp-agent stack through kolla-ansible [1].

Its not up to date, but maybe you can use whats already there.

Best regards
Maximilian Sesterhenn

[1]: https://review.opendev.org/c/openstack/kolla-ansible/+/891622

[Michel Nederlof (mnederlof)]

Hi Maximilian,

Good to know and see, i'm also working on evpn type 5 with ovn-bgp-agent and nb driver, that we are currently using in production, so i'm also trying to upstream the code changes on the ovn-bgp-agent side.

But some are small changes, which makes it easier to upstream them, as the devs have less to review and consider in the change, so i create those as i go along :).

Though ovn is working fine without the hostname being set in ovs, so this code could also benefit from it, as it is another working scenario (in my opinion at least).

- Michel

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906043
Committed: https://opendev.org/openstack/ovn-bgp-agent/commit/c8970b667c984e232fcee7ed9b5de58f1c33fe1d
Submitter: "Zuul (22348)"
Branch: master

commit c8970b667c984e232fcee7ed9b5de58f1c33fe1d
Author: Michel Nederlof <email address hidden>
Date: Thu Jan 18 14:01:18 2024 +0100

    Fix startup if the hostname is not configured in OVS

    When deployed with Kolla Ansible, the hostname field is not configured
    in the external_ids column, and apparently ovn-controller is not
    populating it as well if it is missing.

    Since ovn-controller is using the hostname of the machine if it is not set
    [1][2], it makes sense to do so here as well.

    [1] https://github.com/ovn-org/ovn/blob/v23.09.1/controller/chassis.c#L99
    [2] https://github.com/ovn-org/ovn/blob/v20.03.0/controller/chassis.c#L126

    Closes-Bug: #2049756
    Change-Id: Ic602c3fa9928e00cf4773dae4e91af5d11c758c7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906139

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906139
Committed: https://opendev.org/openstack/ovn-bgp-agent/commit/b36bfdc6cf009872850a728065939de20ad35a02
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit b36bfdc6cf009872850a728065939de20ad35a02
Author: Michel Nederlof <email address hidden>
Date: Thu Jan 18 14:01:18 2024 +0100

    Fix startup if the hostname is not configured in OVS

    When deployed with Kolla Ansible, the hostname field is not configured
    in the external_ids column, and apparently ovn-controller is not
    populating it as well if it is missing.

    Since ovn-controller is using the hostname of the machine if it is not set
    [1][2], it makes sense to do so here as well.

    [1] https://github.com/ovn-org/ovn/blob/v23.09.1/controller/chassis.c#L99
    [2] https://github.com/ovn-org/ovn/blob/v20.03.0/controller/chassis.c#L126

    Closes-Bug: #2049756
    Change-Id: Ic602c3fa9928e00cf4773dae4e91af5d11c758c7
    (cherry picked from commit c8970b667c984e232fcee7ed9b5de58f1c33fe1d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-bgp-agent 2.0.0.0rc1 release candidate.