osrf-websocket-stdio should log real client address

[Galen Charlton]

Currently osrf-websocket-stdio grabs the client IP from REMOTE_ADDR as set by websocketd. Since most/all Evergreen setups have a proxy sitting in front of websocketd (or should), REMOTE_ADDR is most often set to "127.0.0.1", although setups are possible where the proxy and the websocketd server are not the same host.

This isn't particularly useful; instead, it would be more convenient to log the real client IP address. Since both the NGINX and HAProxy configurations shipped with OpenSRF set X-Forwarded-For, we can use instead (as websocketd maps it to an environment variable HTTP_X_FORWARDED_FOR.

[Galen Charlton (gmc)]

A patch is available in user/gmcharlt/lp2047662_log_real_client_ip_for_websocketd / https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2047662_log_real_client_ip_for_websocketd

I'm suggesting this as a wishlist-that-is-arguably-a-bugfix for 3.3.x and maybe 3.2.x, but at first blush looks like it should cherry-pick cleanly into the current RediSRF branch.

[Jason Boyer (jboyer)]

Tested on my system and it does the thing. Signoff branch is at https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/jboyer/lp2047662_websocketd_log_signoff / working/user/jboyer/lp2047662_websocketd_log_signoff