osrf-websocket-stdio should log real client address
Bug #2047662 reported by
Galen Charlton
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenSRF |
Confirmed
|
Wishlist
|
Unassigned | ||
3.2 |
Confirmed
|
Wishlist
|
Unassigned | ||
3.3 |
Confirmed
|
Wishlist
|
Unassigned |
Bug Description
Currently osrf-websocket-
This isn't particularly useful; instead, it would be more convenient to log the real client IP address. Since both the NGINX and HAProxy configurations shipped with OpenSRF set X-Forwarded-For, we can use instead (as websocketd maps it to an environment variable HTTP_X_
description: | updated |
Changed in opensrf: | |
status: | New → Confirmed |
tags: | added: signedoff |
To post a comment you must log in.
A patch is available in user/gmcharlt/ lp2047662_ log_real_ client_ ip_for_ websocketd / https:/ /git.evergreen- ils.org/ ?p=working/ OpenSRF. git;a=shortlog; h=refs/ heads/user/ gmcharlt/ lp2047662_ log_real_ client_ ip_for_ websocketd
I'm suggesting this as a wishlist- that-is- arguably- a-bugfix for 3.3.x and maybe 3.2.x, but at first blush looks like it should cherry-pick cleanly into the current RediSRF branch.