[OVN] ``OVNAgentExtensionManager`` is resetting the ``agent_api`` during the initialization

Bug #2046939 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

The ``OVNAgentExtensionManager`` instance of the OVN agent is resetting the ``agent_api`` member during the extensions manager initialization. The ``OVNAgentExtensionManager`` inherits from ``AgentExtensionsManager``. The ``initialize`` method iterates through the loaded extensions and execute the following methods:
* ``consume_api``: assigns the agent API to the extension.
* ``initialize``: due to a wrong implementation, this method is now assigning None to the agent API, previously assigned.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/903943

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/903944

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/903945

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/903943
Committed: https://opendev.org/openstack/neutron/commit/86efc8be9934713ad79b3415b8b5b72bd475e01c
Submitter: "Zuul (22348)"
Branch: master

commit 86efc8be9934713ad79b3415b8b5b72bd475e01c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 19 10:57:56 2023 +0000

    [OVN] OVN agent extensions correctly consume agent API

    Now the ``OVNAgentExtension`` class do not clear the agent API during
    the extension initialization.

    This patch also passes the agent object to the OVN agent extensions
    as agent API. Any method required will be implemented directly on the
    OVN agent class.

    Closes-Bug: #2046939
    Change-Id: Ia635ca1ff97c3db43a34d3dec6a7f9df154dfe28

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0b1

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/903945
Committed: https://opendev.org/openstack/neutron/commit/2c567e002c4533c59fe9a260dac8d1f773eaa7e6
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 2c567e002c4533c59fe9a260dac8d1f773eaa7e6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 19 10:57:56 2023 +0000

    [OVN] OVN agent extensions correctly consume agent API

    Now the ``OVNAgentExtension`` class do not clear the agent API during
    the extension initialization.

    This patch also passes the agent object to the OVN agent extensions
    as agent API. Any method required will be implemented directly on the
    OVN agent class.

    Closes-Bug: #2046939
    Change-Id: Ia635ca1ff97c3db43a34d3dec6a7f9df154dfe28
    (cherry picked from commit 86efc8be9934713ad79b3415b8b5b72bd475e01c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/903944
Committed: https://opendev.org/openstack/neutron/commit/643dbbbf6bbf7601b3deb07096339e0ec72e57a5
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 643dbbbf6bbf7601b3deb07096339e0ec72e57a5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 19 10:57:56 2023 +0000

    [OVN] OVN agent extensions correctly consume agent API

    Now the ``OVNAgentExtension`` class do not clear the agent API during
    the extension initialization.

    This patch also passes the agent object to the OVN agent extensions
    as agent API. Any method required will be implemented directly on the
    OVN agent class.

    Closes-Bug: #2046939
    Change-Id: Ia635ca1ff97c3db43a34d3dec6a7f9df154dfe28
    (cherry picked from commit 86efc8be9934713ad79b3415b8b5b72bd475e01c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.