Multiple labels for the Library Settings Editor ou selector

Bug #2043899 reported by Jane Sandberg
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

On today's main, the Library Settings Editor has two labels for the OU selector.

Steps to recreate:
1. Go to an Evergreen that has the main branch or rel_3_12 branch loaded.
2. In the staff client, go to Administration > Local Administration
3. Choose Library Settings Editor
4. Note that there are two labels for the org unit selector, "Context Location" (in grey) and Library (above the selector).

Success criteria:

* There is only one label for the org selector on this screen.
* The label is associated with the selector (currently, the "Library" label is, but the "Context Location" label is not). See https://wiki.evergreen-ils.org/doku.php?id=accessibility:forms:labels for more details.

summary: - Small visual regression on the Library Settings Editor ou selector
+ Multiple labels for the Library Settings Editor ou selector
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

The org selector in the Angular circulation patron details screen is also missing its visible label.

Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

The new labeling method I introduced in bug 1999158 turned out to be very incompatible with some screens that have a complicated labeling strategy, like the patron edit form in Angular Circulation. I saw no good way to make it work except to revert to using ARIA labels, as we do in many other components. This makes for a difficult branch to review, since we have such a mixed label strategy for org selectors and the changes affect every single one.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2043899-multiple-org-select-labels

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
assignee: Stephanie Leary (stephanieleary) → nobody
tags: removed: bitesize
tags: added: accessibility
Changed in evergreen:
milestone: 3.12-beta → 3.12-rc
Revision history for this message
Terran McCanna (tmccanna) wrote :

I have checked all of the screens I could think of and I no longer see any duplicate visible labels with this branch applied.

Signed off and merged for inclusion in 3.12.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → Fix Committed
tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.