Link/button issue in clipboard dialog component

Bug #2043424 reported by Stephanie Leary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.10
Fix Released
Low
Unassigned
3.11
Fix Released
Low
Unassigned

Bug Description

In reviewing the core UI components, I found a link/button issue in the clipboard dialog component. Branch coming up.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Hit Enter a little too fast. For posterity, the issue here is that <a> tags that are used for click actions do not offer keyboard support, whereas <button> tags do.

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP2043424-clipboard-dialog-link-button

To test, find a grid that includes the "Copy to Clipboard" action in its context menu. Open the dialog and inspect the button that contains the clipboard value. It should be <button> instead of <a href="javascript:;">.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Works for me! Pushed to main, 3.12, 3.11, and 3.10.

Changed in evergreen:
status: New → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
tags: added: signedoff
Changed in evergreen:
status: Fix Committed → Fix Released
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.