QueryParser.pm - log noise - uninitialized value errors

[Josh Stompro]

EG 3.11.1

I'm seeing 20K log lines a day triggered by use of uninitialized value warnings in QueryParser.pm

Each time a search is made there is a batch of new erroers.

$ fgrep 'Use of uninitialized' osrfsys.log.1 | cut -d " " -f 5- | sort | uniq -c | sort | fgrep QueryParser
      4 open-ils.storage.biblio.multiclass.staged.search_fts.staff: Use of uninitialized value in string eq at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1626.
    244 open-ils.storage.biblio.multiclass.staged.search_fts.staff: Use of uninitialized value in addition (+) at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1661.
    244 open-ils.storage.biblio.multiclass.staged.search_fts.staff: Use of uninitialized value in addition (+) at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1662.
   2580 open-ils.storage.biblio.multiclass.staged.search_fts: Use of uninitialized value in addition (+) at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1661.
   2580 open-ils.storage.biblio.multiclass.staged.search_fts: Use of uninitialized value in addition (+) at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1662.
   4388 open-ils.storage.biblio.multiclass.staged.search_fts: Use of uninitialized value in string eq at /usr/local/share/perl/5.36.0/OpenILS/Application/Storage/QueryParser.pm line 1626.

I added some defined checks to silence them, branch on the way.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Working branch at : user/stompro/lp2043045-queryparser-log-noise-sub-pullup

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp2043045-queryparser-log-noise-sub-pullup

[Jason Boyer (jboyer)]

Excellent, I'm always happy to see logs cleaned up.
Does the thing, searches still do theirs, signoff is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2043045_shush_signoff / working/user/jboyer/lp2043045_shush_signoff

[Galen Charlton (gmc)]

Pushed down to rel_3_11. Thanks, Josh and Jason!