Action column is empty when there is no action to list

[Numan Menekşe]

On any listing page, some actions are defined in the action field. However, when these actions are shown and hidden according to some roles, these actions do not appear in the list. If there is no action to show, the Action column appears empty.

It has to be: If there is no action to be listed, the Action column should be hidden.

[xusongfu (xusongfu)]

Hi,

This is a good suggestion; we will consider optimizing it.

Thank you.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/skyline-console/+/901530

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/skyline-console/+/901530
Committed: https://opendev.org/openstack/skyline-console/commit/54e64ea9fc25045952a9fbfdfbc1689e0c3b5d5a
Submitter: "Zuul (22348)"
Branch: master

commit 54e64ea9fc25045952a9fbfdfbc1689e0c3b5d5a
Author: xusongfu <[e-mail]>
Date: Tue Nov 21 17:53:55 2023 +0800

    fix: Fix action colum of the Table

    Fix action list for listener of loaderbalance

    Closes-Bug: #2042932
    Change-Id: Ie6573cbb7145baf043606c6374ff14ddd83fa4ac

[Numan Menekşe (numanmenekse)]

Thanks for fix.

Is it valid for any page or else DNS, LoadBalancer?

[xusongfu (xusongfu)]

This patch just fixed the LoadBalancer Listener. Is there a similar issue with DNS?

[Numan Menekşe (numanmenekse)]

Yes, it was actually valid for actions that do not have firstAction but have primaryActions. I think the firstAction part should be full, it should be an action.

I think this is the right method ?

[xusongfu (xusongfu)]

Actually firstAction could be empty, such as DNS.

The Set action and Unset action belong to one collection.

We probably should't use firstAction for the Set action, but use moreAction for Unset action.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/skyline-console 4.0.0.0rc1 release candidate.