create-target action accepts invalid auth credentials

[Samuel Allan]

The create-target action has parameters `client-password` and `client-username`. Ceph iscsi has requirements for the password and username (see attached screenshot from ceph dashboard for source):

username: length of 8 to 64 characters and can contain alphanemuric charactors, '.', '@', '-', '_' or ':'

password: length of 12 to 16 characters and can contain alphanemuric charactors, '@', '-', '_' or '/'

However, the create-target action accepts any value. If the username or password given to create-target does not meet the requirements, no error is returned to the user. The target is created, but credentials are not set.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899273

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899273
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/eec2d0d5eab1b1dd27673b5ca338f369f204c1ae
Submitter: "Zuul (22348)"
Branch: master

commit eec2d0d5eab1b1dd27673b5ca338f369f204c1ae
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Oct 25 11:54:55 2023 -0300

    Reject invalid username and password

    This patchset checks that the username and password parameters
    comply with ceph-iscsi requirements.

    Change-Id: Ida720e5381d0ff3446cf88405452f8a3778c7efc
    Fixes-bug: #2040328

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/quincy.2
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/901293

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/901293
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/f23a14b28cf55799fe3afc2d7daefd4320074cee
Submitter: "Zuul (22348)"
Branch: stable/quincy.2

commit f23a14b28cf55799fe3afc2d7daefd4320074cee
Author: Luciano Lo Giudice <email address hidden>
Date: Wed Oct 25 11:54:55 2023 -0300

    Reject invalid username and password

    This patchset checks that the username and password parameters
    comply with ceph-iscsi requirements.

    Change-Id: Ida720e5381d0ff3446cf88405452f8a3778c7efc
    Fixes-bug: #2040328
    (cherry picked from commit eec2d0d5eab1b1dd27673b5ca338f369f204c1ae)