Bootstrap Opac: Personal Information Page contains Links as Buttons

[Garry Collum]

The account information and preferences page in the bootstrap opac (Preferences -> Personal Information) contains several links disguised as buttons: change username, change password, change email, send test email, and change preferred language. These should be changed to buttons.

[Garry Collum (gcollum)]

A proposed patch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=2a3057e129c994626139a7e02e9865726ca743de

To test the change username button, you must enable "allow multiple username changes" in library settings.

To test the send email button, I set up postfix on my machine to send messages locally and added opensrf@localhost to a patron's record.

[Elizabeth Davis (elidavis)]

I have tested this and was able to change username, change password, change email, send test email and changed preferred language.

I will consent to the sign-off on this code with my name, Elizabeth Davis and my email address is <email address hidden>

[Stephanie Leary (stephanieleary)]

The only one of these links that needs to be changed to a <button> is Send Test Email (the one with href="#" that doesn't go anywhere, but triggers a JS function). The rest of these are legitimately links that take the user to other URLs, and it's fine that they're styled with the Bootstrap button classes.

[Stephanie Leary (stephanieleary)]

Here's a branch that copies Garry's changes, but only for the "Send Test Email" button: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2040314-opac-test-email-link-button

His testing notes in #1 still apply for email. We no longer need to enable username changes in the library settings to test this, since that button isn't changing.

[Terran McCanna (tmccanna)]

Stephanie - it looks like your branch in comment #4 changes the file in templates, but not in templates-bootstrap.

[Stephanie Leary (stephanieleary)]

You are right! I've pushed a second commit to handle the templates-bootstrap version as well.

[Terran McCanna (tmccanna)]

Looks great! Thanks Garry and Stephanie!

Fix merged and pushed back as far as 3_10