application name is "unknown" for iSCSI pools

[Nobuto Murata]

The application name for two pools created by the charm are marked as unknown, which means there was no application name specified.

# ceph osd pool ls detail | grep iscsi
pool 19 'iscsi' replicated size 3 min_size 2 crush_rule 0 object_hash rjenkins pg_num 16 pgp_num 16 autoscale_mode on last_change 931 flags hashpspool,selfmanaged_snaps stripe_width 0 pg_num_min 16 target_size_ratio 0.1 application unknown
pool 20 'ceph-iscsi' replicated size 3 min_size 2 crush_rule 0 object_hash rjenkins pg_num 8 pgp_num 8 autoscale_mode on last_change 939 flags hashpspool,selfmanaged_snaps stripe_width 0 pg_num_min 8 target_size_ratio 0.05 application unknown

^^^ the last column

Ceph-iSCSI relies on RBD for both the data and the metadata pool so we can mark those as "rbd".
https://docs.ceph.com/en/latest/rbd/iscsi-overview/

# rbd info --pool iscsi disk-1
rbd image 'disk-1':
        size 5 GiB in 1280 objects
        order 22 (4 MiB objects)
        snapshot_count: 0
        id: 1c0544b74c08
        block_name_prefix: rbd_data.1c0544b74c08
        format: 2
        features: layering, exclusive-lock, object-map, fast-diff, deep-flatten
        op_features:
        flags:
        create_timestamp: Tue Oct 24 11:49:26 2023
        access_timestamp: Tue Oct 24 11:49:26 2023
        modify_timestamp: Tue Oct 24 11:49:26 2023

That will improve the visibility of the pool list in the Ceph dashboard too.

[Nobuto Murata (nobuto)]

app-name=null

$ juju show-unit ceph-mon/0

...

  - relation-id: 15
    endpoint: client
    related-endpoint: ceph-client
    application-data: {}
    related-units:
      ceph-iscsi/1:
        in-scope: true
        data:
          application-name: ceph-iscsi
          broker_req: '{"api-version": 1, "ops": [{"op": "create-pool", "name": "iscsi",
            "replicas": 3, "pg_num": null, "crush-profile": null, "app-name": null,
            "compression-algorithm": null, "compression-mode": null, "compression-required-ratio":

...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899220

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899220
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/ab6d598ddce6b1d0b758d5fa7888d8dc56e15de0
Submitter: "Zuul (22348)"
Branch: master

commit ab6d598ddce6b1d0b758d5fa7888d8dc56e15de0
Author: Luciano Lo Giudice <email address hidden>
Date: Tue Oct 24 20:29:33 2023 -0300

    Set iscsi pools' application

    This patchset sets the default application name for the charm-created
    pools to 'rbd'.

    Closes-bug: #2040274
    Change-Id: I781a2e33b3de9f55b97fddd661214f601fc6134e

[Nobuto Murata (nobuto)]

This fix hasn't been landed to charmhub if I'm not mistaken.

$ juju info ceph-iscsi --base ubuntu@22.04

...

channels: |
  quincy/stable: 21 2023-09-12 (21) 9MB amd64, arm64, ppc64el, s390x
                       9 2022-05-05 (9) 6MB amd64, arm64, ppc64el, s390x
  quincy/candidate: ↑
  quincy/beta: ↑
  quincy/edge: ↑
  latest/stable: –
  latest/candidate: –
  latest/beta: –
  latest/edge: 22 2023-10-03 (22) 10MB amd64, arm64, ppc64el, s390x
  reef/stable: –
  reef/candidate: 22 2023-10-13 (22) 10MB amd64, arm64, ppc64el, s390x

[Nobuto Murata (nobuto)]

Ah, my apologies. I was misdirected by the other issue:
https://bugs.launchpad.net/charm-ceph-iscsi/+bug/2042419

The issue ignored the pool name specified and put the RBD image into the metadata pool.

So the metadata pool is used for rados objects for the gateway config file.

# rados --pool iscsi ls
gateway.conf

and the data pool is used for RBD.

# rados --pool ceph-iscsi ls
rbd_id.disk_1
rbd_directory
rbd_object_map.1a89963bcd7b
rbd_info
rbd_header.1a89963bcd7b

So setting "rbd" to the data pool is correct, but to the metadata pool wasn't precise in the end.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/899858
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/82779e5ff9a579610f2e1b4af557ee4ef2ede202
Submitter: "Zuul (22348)"
Branch: master

commit 82779e5ff9a579610f2e1b4af557ee4ef2ede202
Author: Nobuto Murata <email address hidden>
Date: Wed Nov 1 21:45:59 2023 +0900

    Don't set the default pool as "iscsi"

    "iscsi" is the name of the metadata pool by default in the charm and not
    to be used for tenant data. The charm can fill out the data pool name
    automatically with `def data_pool_name` or can accept a user specified
    value. After fixing the issue, the "iscsi" pool will be used only for
    hosting gateway.conf as a rados object so reflect the purpose into the
    application name for the pool too.

    Also, update the command syntax not to print the deprecation warning:
    "rbd: --user is deprecated, use --id"

    Closes-Bug: #2042419
    Related-Bug: #2040274
    Change-Id: Iec275190854edcc85915d93db233f444c92fbb17

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/quincy.2
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/900072

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/quincy.2
Review: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/900073

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/900072
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/2b88df327f26405108a320114164be9876ce0753
Submitter: "Zuul (22348)"
Branch: stable/quincy.2

commit 2b88df327f26405108a320114164be9876ce0753
Author: Luciano Lo Giudice <email address hidden>
Date: Tue Oct 24 20:29:33 2023 -0300

    Set iscsi pools' application

    This patchset sets the default application name for the charm-created
    pools to 'rbd'.

    Closes-bug: #2040274
    Change-Id: I781a2e33b3de9f55b97fddd661214f601fc6134e
    (cherry picked from commit ab6d598ddce6b1d0b758d5fa7888d8dc56e15de0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/900073
Committed: https://opendev.org/openstack/charm-ceph-iscsi/commit/50bd805fb1b61c871b8c32f4ba2b90586624c636
Submitter: "Zuul (22348)"
Branch: stable/quincy.2

commit 50bd805fb1b61c871b8c32f4ba2b90586624c636
Author: Nobuto Murata <email address hidden>
Date: Wed Nov 1 21:45:59 2023 +0900

    Don't set the default pool as "iscsi"

    "iscsi" is the name of the metadata pool by default in the charm and not
    to be used for tenant data. The charm can fill out the data pool name
    automatically with `def data_pool_name` or can accept a user specified
    value. After fixing the issue, the "iscsi" pool will be used only for
    hosting gateway.conf as a rados object so reflect the purpose into the
    application name for the pool too.

    Also, update the command syntax not to print the deprecation warning:
    "rbd: --user is deprecated, use --id"

    Closes-Bug: #2042419
    Related-Bug: #2040274
    Change-Id: Iec275190854edcc85915d93db233f444c92fbb17
    (cherry picked from commit 82779e5ff9a579610f2e1b4af557ee4ef2ede202)