landscape-config does not start landscape-client service

[Mitch Burton]

This bug was discovered during verification of the fix for LP: #2027613

[ Impact ]

The new ExecCondition in landscape-client.service provided in the patch for LP: #2027613 prevents the final steps of the landscape-config Client configuration wizard from starting the landscape-client service. landscape-config attempts to start the service via systemd to facilitate registration with Landscape Server. However, with the patch, the service cannot start prior to registration.

As a result, landscape-config cannot successful complete registration with Landscape Server.

[ Test Plan ]

a) install landscape-client, execute `sudo landscape-config` and complete the wizard.
expected behaviour: registration is successful and the landscape-client service is running. landscape-client behaves normally for a number of message exchanges and dispatched Landscape actions, such as reboot and package upgrade.

b) let's also make sure that after upgrading landscape-client, it is:
b1) restarted if it was running already
b2) is NOT started if it wasn't running/enabled before

[ Where problems could occur ]

As this is a change to the landscape-config behaviour, problems would likely present as the service not running, the service running when it should not be, or in the registration or setup/config behaviour.

[Andreas Hasenack (ahasenack)]

Mitch, isn't this also needed in lunar? I just checked the pkg/ubuntu/lunar-devel branch and it does not have this patch. I'm adding a lunar task to the bug, but let me know if that's incorrect please.

[Andreas Hasenack (ahasenack)]

And mantic and noble too.

[Mitch Burton (mitchburton)]

I've add MRs for lunar, mantic, and noble. These also address LP: #2027613.

[Launchpad Janitor (janitor)]

This bug was fixed in the package landscape-client - 23.08-0ubuntu4

---------------
landscape-client (23.08-0ubuntu4) noble; urgency=medium

  * d/p/0003-fix-cpuinfo-and-tests.patch: fix ARM and RISCV cpuinfo parsing;
    fix environment var-modifying tests, increase timeout on tests that can
    be slow on these arches (LP: #2046620).

 -- Mitch Burton <email address hidden> Thu, 04 Jan 2023 17:06:26 -0800

[Timo Aaltonen (tjaalton)]

Hello Mitch, or anyone else affected,

Accepted landscape-client into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/23.08-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Mitch, or anyone else affected,

Accepted landscape-client into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/23.02-0ubuntu1~22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Mitch, or anyone else affected,

Accepted landscape-client into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/23.02-0ubuntu1~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Mitch Burton (mitchburton)]

Tested on focal using version 23.02-0ubuntu1~20.04.2, according to the test plan

a) installed and ran `sudo landscape-config`. Progressed through the wizard until

Request a new registration for this computer now? [y/N]: y
System successfully registered.

ubuntu@musical-liger:~$ systemctl is-active landscape-client
active

ubuntu@musical-liger:~$ pgrep landscape
4878
4880
4881
4882
4927

ubuntu@musical-liger:~$ ps u -p 4878 4880 4881 4882 4927
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 4878 0.0 0.1 42992 31172 ? Ss 21:16 0:00 /usr/bin/python3 /usr/bin/landscape-client
landsca+ 4880 0.0 0.2 278568 41936 ? Sl 21:16 0:00 /usr/bin/python3 /usr/bin/landscape-broker --ignore-sigint
landsca+ 4881 0.0 0.2 139052 40552 ? Sl 21:16 0:00 /usr/bin/python3 /usr/bin/landscape-monitor --ignore-sigint
root 4882 0.0 0.2 52556 36616 ? S 21:16 0:00 /usr/bin/python3 /usr/bin/landscape-manager --ignore-sigint
landsca+ 4927 0.0 1.3 389856 224020 ? Rl 21:17 0:14 /usr/bin/python3 /usr/bin/landscape-package-reporter --quiet

landscape-client appears to be behaving normally. I dispatched a reboot, a package upgrade, and a package installation.

b) Installed landscape-client 19.12-0ubuntu4.3
b1) registered via `sudo landscape-config`. Confirmed landscape-client service is running.
Upgraded to landscape-client 23.02-0ubuntu1~20.04.2

The landscape-client service has restarted and is running the latest version. Message exchanges are successful.

ubuntu@engaging-eel:~$ tail /var/log/landscape/broker.log
...
2024-03-27 21:37:51,715 INFO [MainThread] Broker stopped with config /etc/landscape/client.conf
2024-03-27 21:37:52,634 INFO [MainThread] Broker started with config /etc/landscape/client.conf
...

b) Installed landscape-client 19.12-0ubuntu4.3
b2) the landscape-client service is not running
Upgraded to landscape-client 23.02-0ubuntu1~20.04.2

The landscape-client service is still not running:

ubuntu@wise-wallaby:~$ systemctl is-active landscape-client
inactive

ubuntu@wise-wallaby:~$ ls -l /var/log/landscape/
total 0

[Mitch Burton (mitchburton)]

Tested on jammy using version 23.02-0ubuntu1~22.04.2

a) installed and ran `sudo landscape-config`. Progressed through the wizard until

Request a new registration for this computer now? [y/N]: y
System successfully registered.

ubuntu@driven-mudfish:~$ systemctl is-active landscape-client
active

ubuntu@driven-mudfish:~$ pgrep landscape
2930
2931
2932
2933

ubuntu@driven-mudfish:~$ ps u -p 2930 2931 2932 2933
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 2930 0.0 0.2 50772 37268 ? Ss 21:57 0:00 /usr/bin/python3 /usr/bin/landscape-client
landsca+ 2931 0.0 0.3 286392 49004 ? Sl 21:57 0:00 /usr/bin/python3 /usr/bin/landscape-broker --ignore-sigint
landsca+ 2932 0.0 0.2 146128 45296 ? Sl 21:57 0:00 /usr/bin/python3 /usr/bin/landscape-monitor --ignore-sigint
root 2933 0.0 0.2 60072 41224 ? S 21:57 0:00 /usr/bin/python3 /usr/bin/landscape-manager --ignore-sigint

landscape-client appears to be behaving normally. I dispatched a reboot, a package upgrade, and a package installation.

b) Installed landscape-client 19.12-0ubuntu13
b1) registered via `sudo landscape-config`. Confirmed landscape-client service is running.
Upgraded to landscape-client 23.02-0ubuntu1~22.04.2

The landscape-client service has restarted and is running the latest version. Message exchanges are successful.

Restarting services...
 systemctl restart landscape-client.service

ubuntu@select-emu:~$ tail /var/log/landscape/broker.log
...
2024-03-27 22:15:36,058 INFO [MainThread] Broker stopped with config /etc/landscape/client.conf
2024-03-27 22:15:37,246 INFO [MainThread] Broker started with config /etc/landscape/client.conf
...

b) Installed landscape-client 19.12-0ubuntu13
b2) the landscape-client service is not running
Upgraded to landscape-client 23.02-0ubuntu1~22.04.2

The landscape-client service is still not running:
ubuntu@immune-sheep:~$ systemctl is-active landscape-client
inactive

ubuntu@immune-sheep:~$ ls -l /var/log/landscape/
total 0

[Mitch Burton (mitchburton)]

Test on mantic using version 23.08-0ubuntu1.1

a) installed and ran `sudo landscape-config`. Progressed through the wizard until

Request a new registration for this computer now? [y/N]: y
Registration request sent successfully.

ubuntu@expert-bug:~$ systemctl is-active landscape-client
active

ubuntu@expert-bug:~$ pgrep landscape
3197
3198
3199
3200

ubuntu@expert-bug:~$ ps u -p 3197 3198 3199 3200
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 3197 0.0 0.2 54668 39316 ? Ss 22:26 0:00 /usr/bin/python3 /usr/bin/landscape-client
landsca+ 3198 0.0 0.3 217312 50776 ? Sl 22:26 0:00 /usr/bin/python3 /usr/bin/landscape-broker --ignore-sigint
landsca+ 3199 0.0 0.3 80756 50244 ? S 22:26 0:00 /usr/bin/python3 /usr/bin/landscape-monitor --ignore-sigint
root 3200 0.0 0.2 78344 46692 ? S 22:26 0:00 /usr/bin/python3 /usr/bin/landscape-manager --ignore-sigint

landscape-client appears to be behaving normally. I dispatched a reboot, a package upgrade, and a package installation.

b) installed landscape-client 23.08-0ubuntu1
b1) registered via `sudo landscape-config`. Confirmed landscape-client service is running.
Upgraded to landscape-client 23.08-0ubuntu1.1

Restarting services...
 systemctl restart landscape-client.service
Warning: The unit file, source configuration file or drop-ins of landscape-client.service changed on disk. Run 'systemctl daemon-reload' to reload units.

ubuntu@mutual-satyr:~$ tail /var/log/landscape/broker.log
...
2024-03-27 22:33:16,409 INFO [MainThread] Broker stopped with config /etc/landscape/client.conf
2024-03-27 22:33:19,987 INFO [PoolThread-twisted.internet.reactor-1] Sent 569224 bytes and received 2849 bytes in 18.98s.
2024-03-27 22:33:21,107 INFO [MainThread] Broker started with config /etc/landscape/client.conf
...

b) Installed landscape-client 23.08-0ubuntu1
b2) the landscape-client service is not running
Upgraded to landscape-client 23.08-0ubuntu1.1

The landscape-client service is still not running:
ubuntu@rich-airedale:~$ systemctl is-active landscape-client
inactive

ubuntu@rich-airedale:~$ ls -l /var/log/landscape/
total 0

[Timo Aaltonen (tjaalton)]

Hello Mitch, or anyone else affected,

Accepted landscape-client into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/landscape-client/23.08-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Mitch Burton (mitchburton)]

Test on mantic using version 23.08-0ubuntu1.2

a) installed and ran `sudo landscape-config`. Progressed through the wizard until

Request a new registration for this computer now? [y/N]: y
Registration request sent successfully.

ubuntu@free-gorilla:~$ systemctl is-active landscape-client
active

ubuntu@free-gorilla:~$ pgrep landscape
4388
4389
4390
4391

ubuntu@free-gorilla:~$ ps -u -p 4388 4389 4390 4391
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
root 4388 0.0 0.2 54664 39260 ? Ss 22:20 0:00 /usr/bin/python3 /usr/bin/landscape-client
landsca+ 4389 0.0 0.3 217312 50288 ? Sl 22:20 0:00 /usr/bin/python3 /usr/bin/landscape-broker --ignore-sigint
landsca+ 4390 0.0 0.3 80696 50212 ? S 22:20 0:00 /usr/bin/python3 /usr/bin/landscape-monitor --ignore-sigint
root 4391 0.0 0.2 78344 46692 ? S 22:20 0:00 /usr/bin/python3 /usr/bin/landscape-manager --ignore-sigint

landscape-client appears to be behaving normally. I dispatched a reboot, a package upgrade, and a package installation.

b) installed landscape-client 23.08-0ubuntu1
b1) registered via `sudo landscape-config`. Confirmed landscape-client service is running.
Upgraded to landscape-client 23.08-0ubuntu1.2

Restarting services...
 systemctl restart landscape-client.service

ubuntu@golden-sunfish:~$ tail /var/log/landscape/broker.log
...
2024-04-23 22:25:46,149 INFO [MainThread] Broker stopped with config /etc/landscape/client.conf
2024-04-23 22:25:47,319 INFO [MainThread] Broker started with config /etc/landscape/client.conf
...

b) Installed landscape-client 23.08-0ubuntu1
b2) the landscape-client service is not running
Upgraded to landscape-client 23.08-0ubuntu1.2

landscape-client.service is a disabled or a static unit not running, not starting it.

The landscape-client service is still not running:
ubuntu@logical-horse:~$ systemctl is-active landscape-client
inactive

ubuntu@logical-horse:~$ ls -l /var/log/landscape/
total 0