Ramping down from turbo flickers if smooth steps enabled

[Niku Toivola]

Steps to reproduce:

1. Install a recent revision of the multi-channel branch (verified on rev 781 and newer)
2. Factory reset and go to advanced UI
3. Set ramp ceiling to 120 or 130
4. Enable smooth ramping
5. Enable smooth steps
6. Turn on and go to turbo
7. 1H or 2H to ramp down => light flickers rapidly instead of ramping down, drops to ramp ceiling when released

This only happens with smooth ramping and smooth steps enabled and ramp ceiling < 150. I have verified this on Wurkkos TS10, TS11 and TS25.

I imagine this is related to how ramping down from turbo first steps down to ramp ceiling before ramping down from there, but in smooth steps mode that initial step down somehow doesn't work right.

Probably related: when ramping down from turbo in stepped ramp mode with ramp ceiling < 150, the initial step down is not smooth but the steps after that are.

[Selene ToyKeeper (toykeeper)]

Thanks for finding this. Fixed in the latest revision.

[Niku Toivola (niku-toivola)]

Thanks, that was a quick fix! Confirmed that it no longer flickers, just blinks once when ramping down from turbo, as per your FIXME comment.

The attached patch seems to fix that, unless there's some side effect or other scenario I'm missing?