sunbeam requirement check should also check the storage size available

[nikhil kshirsagar]

The requirements check in sunbeam currently seems to only check memory and CPU, but it should also check available storage. A test deployment I tried failed with "no storage space left" but it could have been warned about in the requirements check.

ubuntu@sunbeamtest:/root$ sunbeam cluster bootstrap --accept-defaults
WARNING: Minimum system requirements (4 core CPU, 16 GB RAM) not met.
⠇ Deploying OpenStack Control Plane to Kubernetes (this may take a while) ... waiting for services to come online (1/23)Exception in callback create_task_with_handler.<locals>._task_result_exp_handler(task_name='tmp', logger=None)(<Task finishe...t on device')>) at /snap/openstack/274/lib/python3.10/site-packages/juju/jasyncio.py:39
handle: <Handle create_task_with_handler.<locals>._task_result_exp_handler(task_name='tmp', logger=None)(<Task finishe...t on device')>) at /snap/openstack/274/lib/python3.10/site-packages/juju/jasyncio.py:39>
Traceback (most recent call last):
  File "/snap/openstack/274/lib/python3.10/site-packages/juju/jasyncio.py", line 41, in _task_result_exp_handler
    task.result()
  File "/snap/openstack/274/lib/python3.10/site-packages/juju/client/facade.py", line 486, in wrapper
    reply = await f(*args, **kwargs)
  File "/snap/openstack/274/lib/python3.10/site-packages/juju/client/_client3.py", line 760, in Next
    reply = await self.rpc(msg)
  File "/snap/openstack/274/lib/python3.10/site-packages/juju/client/overrides.py", line 114, in rpc
    result = await self.connection.rpc(msg, encoder=TypeEncoder)
  File "/snap/openstack/274/lib/python3.10/site-packages/juju/client/connection.py", line 675, in rpc
    raise errors.JujuAPIError(result)
juju.errors.JujuAPIError: write /var/log/juju/audit.log: no space left on device

[James Page (james-page)]

Sounds like a sensible addition to the pre-flight checks before cluster bootstrap and add node operations.