[j:linux-intel-iotg][j:linux-intel-iot-realtime] Cannot set frame preemption
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-intel-iotg (Ubuntu) |
Fix Released
|
Undecided
|
Philip Cox | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
This is a public version of https:/
[Summary]
System cannot set frame preemption via the ethtool-rt from snap store[1], will got netlink error.
[1] https:/
u@u-Alder-
netlink error: frame preemption settings update failed
netlink error: Invalid argument
u@u-Alder-
81
u@u-Alder-
Frame preemption settings for enp1s0:
enabled: not enabled
additional fragment size: 0
verified: 0
verification disabled: 1
[Steps to reproduce]
1. sudo snap install ethtool-ty --devmode --edge
2.sudo ethtool-rt.ethtool --set-frame-
3.sudo ethtool-rt.ethtool --show-
[Expected result]
Set frame preemption successfully.
[Actual result]
Got netlink error.
[Failure rate]
3/3
[Additional information]
CID: 202305-31589
SKU: ADL-S
system-
system-
bios-version: RPLISFI1.
CPU: 12th Gen Intel(R) Core(TM) i3-12100E (8x)
GPU: 00:02.0 VGA compatible controller [0300]: Intel Corporation Device [8086:4692] (rev 0c)
kernel-version: 5.15.0-
[Stage]
Issue reported and logs collected right after it happened
-------
Philip Cox (philcox) wrote on 2023-09-07:   #4
After going through the code, it looks like this is caused by the variable fpcmd->
if (fpcmd-
return -EINVAL;
And this is causing the the --set-frame-
ubuntu@adl-p:~$ sudo ethtool-rt.ethtool --set-frame-
netlink error: frame preemption settings update failed
netlink error: Invalid argument
81
ubuntu@adl-p:~$
I see in igc.h that there is a #define for IGC_I225_
#define IGC_I225_
This is set in igc_tsn_
static int igc_tsn_
{
...
adapter-
adapter-
...
}
but igc_tsn_
-------
Lai Jun Ann (laijunann-intel) wrote 12 hours ago: #12
0001-igc-
The patch is ready and uploaded. Below shows the testing done with the patch:
oot@ubuntu-
Frame preemption settings for enp1s0:
enabled: enabled
additional fragment size: 68
verified: 0
root@ubuntu-
root@ubuntu-
root@ubuntu-
Frame preemption settings for enp1s0:
enabled: not enabled
additional fragment size: 68
verified: 0
root@ubuntu-
root@ubuntu-
Frame preemption settings for enp1s0:
enabled: enabled
additional fragment size: 68
verified: 0
--------------
Philip Cox (philcox) wrote 20 minutes ago:   #13
I've tested the patch as well, and it works. Thanks.
CVE References
Changed in linux-intel-iotg (Ubuntu): | |
status: | New → Confirmed |
Changed in linux-intel-iotg (Ubuntu Jammy): | |
status: | New → Confirmed |
status: | Confirmed → Triaged |
status: | Triaged → In Progress |
Changed in linux-intel-iotg (Ubuntu): | |
status: | Confirmed → Triaged |
status: | Triaged → In Progress |
Changed in linux-intel-iotg (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in linux-intel-iotg (Ubuntu Jammy): | |
status: | In Progress → Fix Committed |
Changed in linux-intel-iotg (Ubuntu): | |
status: | Fix Committed → Fix Released |
This bug is awaiting verification that the linux-intel- iotg/5. 15.0-1044. 50 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- jammy-linux- intel-iotg' to 'verification- done-jammy- linux-intel- iotg'. If the problem still exists, change the tag 'verification- needed- jammy-linux- intel-iotg' to 'verification- failed- jammy-linux- intel-iotg' .
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!