delete share network subnet on share network deletion

[kiran pawar]

When share network is deleted, we check if only 1 share network subnet is associated with share network. But we end up deleting share network in db without deleting that single share network subnet associated with share network. This results in zombie share network subnet entries in db.

We used below query and it returns non-zero result.

MariaDB [manila]> SELECT COUNT(id) FROM share_network_subnets WHERE deleted='False' AND share_network_id IS NULL;

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/896541

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/896541
Committed: https://opendev.org/openstack/manila/commit/cd767dd468fd7c99dc24e7e54262be4e3ba9aaa9
Submitter: "Zuul (22348)"
Branch: master

commit cd767dd468fd7c99dc24e7e54262be4e3ba9aaa9
Author: Kiran Pawar <email address hidden>
Date: Tue Sep 26 13:17:44 2023 +0000

    Delete share network subnet during network deletion

    Share network subnet is deleted during share network deletion which was
    missing earlier causing lots of stale db entries.

    Change-Id: Idb58b4ca389cfb1aaf8f9f1f8aa2fd15979c4872
    Closes-bug: #2037422

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Goutham Pacha Ravi <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/899521
Reason: Bad rebase

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.