Search Preferences: labels and form fields are not associated with each other

[Jane Sandberg]

Steps to recreate:

1. Install aXe or WAVE browser extension
2. In the Web client, go to Search > Search the Catalog
3. Press the "Search Preferences" button
4. Run your browser extension
5. Note that:
    * Preferred Library combobox is associated with a whole bunch of labels
    * Default Search Pane combobox is not associated with its label
    * Search Results Per Page is not associated with its label
    * Exclude Electronic Resources checkbox is not associated with its label

[Stephanie Leary (stephanieleary)]

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2036313-search-prefs-form-labels

Adds <label> tags to the last three form fields on the search preferences screen:

* Default Search Pane
* Search Results Per Page
* Exclude Electronic Resources

To test, visit /eg2/en-US/staff/catalog/prefs (adjusting your locale) and run WAVE or Axe Dev Tools to get a report on form fields without labels.

With the branch for bug 1999158 in place, all form fields should be labeled. Without that patch, the Default Search Library and Preferred Library will be missing labels, but the three listed above will be correctly labeled.

[Ruth Frasur Davis (redavis)]

I have run the Axe DevTools in both a patched and non-patched environment for comparison. I confirm that the form element label issues described in the original LP ticket have been corrected. I consent to add my sign off using my username, rfrasur, and email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Looks good! Thanks Stephanie and Ruth. Fix committed to main and pushed back to 3.11. (Did not apply cleanly to 3.10.)