open-ils.actor.container.retrieve_by_class doesn't properly handle missing bucketOwnerId

[Jason Boyer]

Affects all supported versions of Eg.

The comment for open-ils.actor.container.retrieve_by_class claims that if a userid is not sent as the second param that it will use the authtoken to determine the userid. That sounds great, especially if a discovery layer wants to request all of a user's lists and doesn't necessary track the user's id from the ILS. The function takes takes about half of the necessary steps to use the authtoken but trips right at the finish line. Quick branch coming soon.

[Jason Boyer (jboyer)]

Here is a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2036265_take_this_authtoken_please / working/user/jboyer/lp2036265_take_this_authtoken_please

[Jane Sandberg (sandbergja)]

Good catch, and good fix! Thanks, Jason! I exercised this in the srfsh with:

login admin demo123
request open-ils.actor open-ils.actor.container.retrieve_by_class "authtoken", null, "biblio"

Without your patch, it gives me no data. With your patch, it actually gives me some bucket data. Pushed to rel_3_10 and up.