OPAC course reserves link display shouldn't depend on search library

[Jeff Davis]

The "Search Courses" and "Browse Courses" links appear in the OPAC based on the relevant library's "Opt Org Unit into the Course Materials Module" org setting. But which library is the relevant one? Currently the OPAC checks the setting for the search library (locg param) first, then the physical_loc, then falls back to the top of the org tree, like so:

$ctx->{course_ou} = int($self->cgi->param('locg')) || $self->ctx->{physical_loc} || $self->ctx->{aou_tree}->()->id;

Depending on your local setup, this can mean that the course reserves links appear and disappear from the OPAC based on your search location, which is confusing for users. I think it makes more sense to ignore locg here, and just display the links if "Opt Org Unit into the Course Materials Module" is true at the physical_loc:

$ctx->{course_ou} = $self->ctx->{physical_loc} || $self->ctx->{aou_tree}->()->id;

Should we switch to physical_loc, or does displaying the links based on search location work better in some environments? Should copy location groups (the loc param) be taken into account?

[Jeff Davis (jdavis-sitka)]

Well, here's a working branch that ignores locg: user/jeffdavis/lp2035389-course-reserves-link-display-scope / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2035389-course-reserves-link-display-scope

[Jane Sandberg (sandbergja)]

Seems very reasonable to me, thanks Jeff! Signoff at user/sandbergja/lp2035389-course-reserves-link-display-scope-signoff

[Terran McCanna (tmccanna)]

Thanks Jeff & Jane! Fix committed and pushed as far back as 3.10.