[needs-packaging] arm-trusted-firmware-s32

[Laider Lai]

[needs-packaging] arm-trusted-firmware-s32 (2.5-bsp37.0-0ubuntu1)
For Erlangen project, we have to provide the NXP S32G arm-trusted-firmware to the customer via Ubuntu archive (universe).

URL: https://launchpad.net/~nemos-team/+archive/ubuntu/archive-target/+packages
Source code: https://code.launchpad.net/~nemos-team/nemos/+git/arm-trusted-firmware-s32/+ref/ubuntu/archive
License: https://git.launchpad.net/~nemos-team/nemos/+git/arm-trusted-firmware-s32/tree/debian/copyright
Notes: The NXP S32G arm-trusted-firmware (ATF) [Noble]

This package has dependencies for the other 3 [needs-packaging] bugs and should wait for them to be approved into the target archive.
1. (LP: #2043448)
2. (LP: #2034650)
3. (LP: #2034648)

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Dave Jones (waveform)]

Where is the upstream repo for this package? d/changelog claims that the base version is from git tag "bsp37.0-2.5" but the repo pointed to in d/control (https://source.codeaurora.org/external/autobsps32/arm-trusted-firmware) doesn't exist (in fact the whole source.codeaurora.org site appears to have disappeared according to https://bye.codeaurora.org/), and I can't find that tag in any of the arm-trusted-firmware repos pointed to from that page (the NXP GitHub or QUIC GitLab). Nor does it appear in the repo pointed to by d/watch (which also implies that's incorrect too).

[Isaac True (itrue)]

Hi Dave,

Sorry those repos were decommissioned and taken offline by NXP a few months ago. I'll update the packages with the new GitHub repos ASAP.

[Dave Jones (waveform)]

Ah, is the upstream repo https://github.com/nxp-auto-linux/arm-trusted-firmware by any chance? Just discovered that while looking at the associated u-boot package in LP: #2034650.

[Isaac True (itrue)]

Yes that's the one. Most NXP S32 BSP content is hosted under the nxp-auto-linux GH account

[Isaac True (itrue)]

I've updated the URLs in the git repo

[Isaac True (itrue)]

I've updated the copyright information in the repository. I've also made a few changes to the build process in order to enable UEFI secure boot on the target platform.

[Laider Lai (laiderlai)]

Please hold on for this request.
Because the same platform's kernel resources may have some limitations.

We have to confirm the find public method about the kernel resources. Tks.

[Laider Lai (laiderlai)]

After checking with the HWE team, the kernel resources are okay to be published to the Ubuntu archive.
Therefore, the release target (Ubuntu archive) review process can continue.

[Lucas Kanashiro (lucaskanashiro)]

Hi,

I took a look at the current state of the package in the git repository and I have some notes to share:

- Source packag name: why did you decide to use arm-trusted-firmware-s32 when
  upstream names it as arm-trusted-firmware? I was not able to find the reason
  behind that decision.

- d/watch: it is not working properly. There is also a typo in the
  filenamemangle option:

diff --git a/debian/watch b/debian/watch
index 73f7a4b86..8af606be8 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,6 +1,6 @@
 version=4
 opts="\
-filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firware-s32-$2-$1\.tar\.gz/,\
+filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firmware-s32_$2-$1\.tar\.gz/,\
 uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/,\
 " \
 https://github.com/nxp-auto-linux/arm-trusted-firmware/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz

  When trying to run uscan to download the version your are packaging it fails:

$ uscan --verbose --download-version 2.5-bsp37.0
uscan info: uscan (version 2.20.2ubuntu2) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="arm-trusted-firmware-s32" version="2.5-bsp37.0-8" (as seen in debian/changelog)
uscan info: package="arm-trusted-firmware-s32" version="2.5-bsp37.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="arm-trusted-firmware-s32" version="2.5-bsp37.0"
uscan info: Process watch file at: debian/watch
    package = arm-trusted-firmware-s32
    version = 2.5-bsp37.0
    pkg_dir = .
uscan info: opts: filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firmware-s32_$2-$1\.tar\.gz/,uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/,
uscan info: line: https://github.com/nxp-auto-linux/arm-trusted-firmware/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Parsing filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firmware-s32_$2-$1\.tar\.gz/
uscan info: Parsing uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/
uscan info: line: https://github.com/nxp-auto-linux/arm-trusted-firmware/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Last orig.tar.* tarball version (from debian/changelog): 2.5-bsp37.0
uscan info: Download the --download-version specified version: 2.5-bsp37.0
uscan info: Requesting URL:
   https://github.com/nxp-auto-linux/arm-trusted-firmware/tags
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/nxp\-auto\-linux\/arm\-trusted\-firmware\/tags)?.*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   /nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp38.0-2.5.tar.gz (2.5-bsp38.0) index=2.5-bsp38.0-1
   /nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp37.0-2.5.tar.gz (2.5-bsp37.0) index=2.5-bsp37.0-1 matched with the download version
   /nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp36.0-2.5.tar.gz (2.5-bsp36.0) index=2.5-bsp36.0-1
   /nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp35.0-2.5.tar.gz (2.5-bsp35.0) index=2.5-bsp35.0-1
   /nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp34.2-2.5.tar.gz (2.5-bsp34.2) index=2.5...

[Isaac True (itrue)]

Hi Lucas,

I'll answer your first few questions:

> Source packag name

It's called arm-trusted-firmware-s32 as it's a fork of arm-trusted-firmware with added support for the NXP S32 family of SoCs. This fork is incompatible with (and a different version to) the arm-trusted-firmware package already present in the archives.

> here is also a typo in the filenamemangle option

Thanks for catching that - I've changed it.

> When trying to run uscan to download the version your are packaging it fails

This works fine for me (after fixing the filenamemangle):

$ uscan --verbose --download-version 2.5-bsp37.0
uscan info: uscan (version 2.22.1ubuntu1) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="arm-trusted-firmware-s32" version="2.5-bsp37.0-8" (as seen in debian/changelog)
uscan info: package="arm-trusted-firmware-s32" version="2.5-bsp37.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="arm-trusted-firmware-s32" version="2.5-bsp37.0"
uscan info: Process watch file at: debian/watch
    package = arm-trusted-firmware-s32
    version = 2.5-bsp37.0
    pkg_dir = .
uscan info: opts: filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firmware-s32-$2-$1\.tar\.gz/,uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/,
uscan info: line: https://github.com/nxp-auto-linux/arm-trusted-firmware/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Parsing filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/arm-trusted-firmware-s32-$2-$1\.tar\.gz/
uscan info: Parsing uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/
uscan info: line: https://github.com/nxp-auto-linux/arm-trusted-firmware/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Last orig.tar.* tarball version (from debian/changelog): 2.5-bsp37.0
uscan info: Download the --download-version specified version: 2.5-bsp37.0
uscan info: Requesting URL:
   https://github.com/nxp-auto-linux/arm-trusted-firmware/tags
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/nxp\-auto\-linux\/arm\-trusted\-firmware\/)?.*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp38.0-2.5.tar.gz (2.5-bsp38.0) index=2.5-bsp38.0-1
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp38.0-2.5.tar.gz (2.5-bsp38.0) index=2.5-bsp38.0-1
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp37.0-2.5.tar.gz (2.5-bsp37.0) index=2.5-bsp37.0-1 matched with the download version
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp37.0-2.5.tar.gz (2.5-bsp37.0) index=2.5-bsp37.0-1 matched with the download version
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp36.0-2.5.tar.gz (2.5-bsp36.0) index=2.5-bsp36.0-1
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp36.0-2.5.tar.gz (2.5-bsp36.0) index=2.5-bsp36.0-1
   https://github.com/nxp-auto-linux/arm-trusted-firmware/archive/refs/tags/bsp35.0-2.5.tar.gz (2.5-bsp35.0) index=2.5-bsp35.0-1
   https://...

[Isaac True (itrue)]

I've updated the maintainers and copyright holders as you suggested.

Regarding the changelog, we'd definitely prefer to keep the changelog intact, if possible.

[Dave Jones (waveform)]

It looks like all the required changes have now been made, and I'd be okay sponsoring this to noble (though as a new package this will still require "ack" by an archive admin). One final quick query:

Currently, in the linked PPA, there are only versions for mantic, lunar, and jammy. Would I be correct in assuming that the mantic one would now be intended for noble, and what should the version number be (e.g. should the ~ubuntu23.10.1 be removed)? I'm happy making this trivial change and uploading if someone can confirm the desired version here.

[Dave Jones (waveform)]

Oh, one other query -- I'm assuming this is somewhere but I've not found it in the sponsoring list. Is there a needs-packaging bug for nemos-dev-key somewhere? Given it's in the build-deps for this package, it'll need to be uploaded as well for this to build successfully, and while I can see the needs-packaging bugs for the other build-deps like u-boot-s32 and optee-os-s32, I can't see nemos-dev-key?

[Laider Lai (laiderlai)]

Hi Dave,

Thanks for your feedback. We missed creating a needs-packaging bug for the nemo-dev-key.
As your comment, it'll need to be uploaded.

The LP: #2043448 is created as a needs-packaging bug.
Thanks for your effort to review it. Tks.

[Dave Jones (waveform)]

Excellent! Looks like all concerns are now addressed. Regarding the nemos-dev-key package, tsimonq2 has kindly reviewed and sponsored that package. The other build-deps that need sponsoring for this package are optee-os-s32 in LP: #2034648 and u-boot-s32 in LP: #2034650. I'm currently checking on those but assuming there's nothing further down the dependency tree that's missing I should be able to sponsor this during my patch-pilot shift.

[Laider Lai (laiderlai)]

*Since the development series is moved to Noble. Update the description target to Noble.

[Laider Lai (laiderlai)]

Hi Dave Jones,

We know ATF has dependencies with optee-os-32 and u-boot-s32 and we should wait for them to be accepted first.

Since the u-boot-s32 is updated for reviewer comments.
The ATF is also updated to arm-trusted-firmware-s32 - 2.5-bsp37.0-0ubuntu17.
Tks.

[Laider Lai (laiderlai)]

Reference comments from other cases, refine version 2.5-bsp37.0-0ubuntu1 in PPA.