openafs-modules-dkms FTBS with linux 6.5 on mantic

[Andrea Righi]

[Impact]

/var/lib/dkms/openafs/1.8.10/build/src/crypto/hcrypto/kernel/config.h:94:20: error: static declaration of ‘abort’ follows non-static declaration
   94 | static_inline void abort(void) {osi_Panic("hckernel aborting\n");}
      | ^~~~~
In file included from ./include/linux/kernel.h:29,
                 from ./arch/x86/include/asm/percpu.h:27,
                 from ./arch/x86/include/asm/preempt.h:6,
                 from ./include/linux/preempt.h:79,
                 from ./include/linux/spinlock.h:56,
                 from ./include/linux/wait.h:9,
                 from /var/lib/dkms/openafs/1.8.10/build/src/afs/sysincludes.h:118,
                 from /var/lib/dkms/openafs/1.8.10/build/src/crypto/hcrypto/kernel/config.h:30:
./include/linux/panic.h:36:6: note: previous declaration of ‘abort’ with type ‘void(void)’
   36 | void abort(void);
      | ^~~~~

[Test case]

 $ sudo apt install openafs-modules-dkms

[Fix]

Change openafs-modules-dkms code to support the new 6.5 kernel ABI and avoid the duplicate declaration of abort().

[Regression potential]

We may experience regressions in systems that are using openafs, especially with the new 6.5 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 23.10
Package: openafs-modules-dkms 1.8.10-1ubuntu1
ProcVersionSignature: User Name 6.5.0-4.4-generic 6.5.0
Uname: Linux 6.5.0-4-generic x86_64
NonfreeKernelModules: zfs
ApportVersion: 2.27.0-0ubuntu2
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudBuildName: server
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSerial: 20230823
CloudSubPlatform: config-disk (/dev/vdb)
Date: Tue Sep 5 08:30:18 2023
PackageArchitecture: all
ProcEnviron:
 LANG=C.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: openafs
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Righi (arighi)]

debdiff in attach allows to build openafs-linux-dkms with Linux 6.5.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "openafs-fix-linux-6.5.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Daniel Bosk (daniel-bosk)]

This also applies on Lunar (23.04 LTS). Seems to be no fix there.