Make some ptp-notification parameters configurable

Bug #2033539 reported by Caio Bruchert
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Caio Bruchert

Bug Description

Brief Description
-----------------
To allow more flexibility to the user, The following PTP parameters
needs to be exposed to Helm Charts overrides configuration:

ptp-notification-v1:
  - ptp4lClockClassLockedList

ptp-notification-v2:
  - ptp4lClockClassLockedList
  - ptp4lUtcOffset
  - phc2sysToleranceLow
  - phc2sysToleranceHigh

Severity
--------
Major

Steps to Reproduce
------------------
NA

Expected Behavior
------------------
Allow the listed parameters values to be configurable

Actual Behavior
----------------
The listed parameters values are hard coded

Reproducibility
---------------
Reproducible

System Configuration
--------------------
PTP

Branch/Pull Time/Commit
-----------------------
NA

Last Pass
---------
NA

Timestamp/Logs
--------------
NA

Test Activity
-------------
NA

Workaround
----------
NA

Caio Bruchert (cbrucher)
Changed in starlingx:
assignee: nobody → Caio Bruchert (cbrucher)
Changed in starlingx:
status: New → In Progress
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.9.0 stx.networking
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ptp-notification-armada-app (master)

Reviewed: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/893103
Committed: https://opendev.org/starlingx/ptp-notification-armada-app/commit/63ba400fcd82fca0cfd616ced483bad95511230e
Submitter: "Zuul (22348)"
Branch: master

commit 63ba400fcd82fca0cfd616ced483bad95511230e
Author: Caio Bruchert <email address hidden>
Date: Fri Aug 25 15:51:10 2023 -0300

    Make ptp-notification parameters configurable

    To allow more flexibility to the user, The following PTP parameters
    are being exposed to Helm Charts overrides configuration:

    ptp-notification-v1:
    - ptp4lClockClassLockedList

    ptp-notification-v2:
    - ptp4lClockClassLockedList
    - phc2sysToleranceThreshold

    Test Plan:
    PASS: Build containers and helm charts
    PASS: Deploy ptp-notification
    PASS: v1 api - test ptp4lClockClassLockedList with the default,
                   non-default and invalid lists
    PASS: v2 api - test ptp4lClockClassLockedList with the default,
                   non-default and invalid lists
    PASS: v2 api - test phc2sysToleranceThreshold with commandline option
    PASS: v2 api - test phc2sysToleranceThreshold with config file

    Closes-bug: 2033539

    Change-Id: I7dc915d99a91ff405c4cca4f1e1c1bf3a3559a4e
    Signed-off-by: Caio Bruchert <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ptp-notification-armada-app (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ptp-notification-armada-app (master)

Reviewed: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/895981
Committed: https://opendev.org/starlingx/ptp-notification-armada-app/commit/f2542a59f14a35764c7a74cc683185d8b48ecb65
Submitter: "Zuul (22348)"
Branch: master

commit f2542a59f14a35764c7a74cc683185d8b48ecb65
Author: Cole Walker <email address hidden>
Date: Wed Sep 20 13:12:20 2023 -0400

    Update default ptp4lClockClassLockedList values

    In order to better support the default configuration when
    ptp-notification is deployed on a BC, the ptp4lClockClassLockedList
    values should in include 135 as a locked clockClass.

    This change ensures that classes 6, 7 and 135 are considered acceptable
    for the ptp-notification locked state by default, with the ability to
    override the acceptable clockClasses available to the user.

    Test plan:
    PASS: Build ptp-notification helm charts
    PASS: Deploy ptp-notification
    PASS: v1 api - test ptp4lClockClassLockedList with the default list
    PASS: v2 api - test ptp4lClockClassLockedList with the default list

    Partial-bug: 2033539

    Signed-off-by: Cole Walker <email address hidden>
    Change-Id: Ic569c373dc2ddf1771e83b12832ef1460266c93a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to root (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/896580

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ptp-notification-armada-app (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/c/starlingx/root/+/896580
Committed: https://opendev.org/starlingx/root/commit/e644e5e59edf4389adcc251a229e56ef9c9d53e8
Submitter: "Zuul (22348)"
Branch: master

commit e644e5e59edf4389adcc251a229e56ef9c9d53e8
Author: Caio Bruchert <email address hidden>
Date: Tue Sep 26 15:07:35 2023 -0300

    Update image tags for ptp-notification images

    Update the following image tags:

    notificationservice-base
    stx.9.0-v2.1.2

    notificationservice-base-v2
    stx.9.0-v2.1.2

    Partial-bug: 2033539
    Partial-bug: 2036293

    Signed-off-by: Caio Bruchert <email address hidden>
    Change-Id: I62bff6c51ae44a9844eb2f4e31b3f21fe1adcc2c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ptp-notification-armada-app (master)

Reviewed: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/896583
Committed: https://opendev.org/starlingx/ptp-notification-armada-app/commit/5da5f961a687e4d8a875ac7dc71bd3ed4a283cab
Submitter: "Zuul (22348)"
Branch: master

commit 5da5f961a687e4d8a875ac7dc71bd3ed4a283cab
Author: Caio Bruchert <email address hidden>
Date: Tue Sep 26 15:38:12 2023 -0300

    [PTP] Update image tags in helm charts

    Update the image tags for:

    notificationservice-base
    stx.9.0-v2.1.2

    notificationservice-base-v2
    stx.9.0-v2.1.2

    Partial-bug: 2033539
    Partial-bug: 2036293

    Depends-on: https://review.opendev.org/c/starlingx/root/+/896580

    Change-Id: I8fa1a4028a310d38c3154ff5d0290a02900735a1
    Signed-off-by: Caio Bruchert <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.