Juju lint doesn't recognize COS

[Bas de Bruijne]

The bundle attached uses cos instead of lma in an OpenStack model which leads to the following output:

~~~~~~~
~$ juju-lint -c /snap/juju-lint/current/contrib/fcb-yoga-jammy.yaml bundle.yaml
2023-08-30 12:14:08 [INFO] juju-lint version 1.1.0 starting...
        * Config directory: /home/ubuntu/.config/juju-lint
        * Cloud type: Unknown
        * Manual file: bundle.yaml
        * Rules files: ['/snap/juju-lint/current/contrib/fcb-yoga-jammy.yaml']
        * Log level: INFO

2023-08-30 12:14:08 [WARNING] Regex autodetection feature of the eq operator is deprecated. It will only check for equality in the future. Please use the search operator for regex checks.
2023-08-30 12:14:08 [INFO] [bundle.yaml] Linting manual file...
2023-08-30 12:14:08 [WARNING] [bundle.yaml] [manual/manual] Setting cloud-type to 'openstack'. Deployment has these charms: {'nova-cloud-controller', 'nova-compute', 'neutron-api', 'glance', 'keystone', 'openstack-dashboard'} that are typically from openstack.
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application ceph-mon has incorrect setting for 'nagios_additional_checks_critical': Expected True, got False
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application ceph-mon has incorrect setting for 'nagios_additional_checks': Expected '{"ceph_slow_requests": "slow requests"}', got ''
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application hacluster-vault has config for 'cluster_count' which is less than 3: 1
2023-08-30 12:14:08 [WARNING] [bundle.yaml] [manual/manual] Usable MTU for a tenant network is less than 1500.

2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application neutron-api has incorrect setting for 'global-physnet-mtu': Expected 9000, got 1500
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] dev/sdX or/dev/vgX should not be used as ephemeral-devices. See lp#1999263
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application nrpe has incorrect setting for 'lacp_bonds': Should not be ''
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Application nrpe has incorrect setting for 'netlinks': Should not be ''
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Endpoint 'nrpe:nrpe-external-master' is missing relations with: ['bcache-tuning', 'octavia-ovn-chassis', 'ovn-chassis', 'telegraf']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'nrpe' missing on machines: ['7', '8']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'telegraf' missing on machines: ['7', '8']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'filebeat' missing on machines: ['7', '8']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'landscape-client' missing on machines: ['0', 'lxd:0', '1', 'lxd:1', '2', 'lxd:2', '3', 'lxd:3', '4', 'lxd:4', '5', 'lxd:5', '6', '7', '8']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'ubuntu-advantage' missing on machines: ['7', '8']
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'ubuntu-advantage' not recognised
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Charm 'cos-proxy' not recognised
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'elasticsearch' is missing
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'grafana' is missing
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'graylog' is missing
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'landscape-server' is missing
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'nagios' is missing
2023-08-30 12:14:08 [ERROR] [bundle.yaml] [manual/manual] Ops charm 'prometheus2' is missing
2023-08-30 12:14:08 [WARNING] Multi-model is not supported yet. Please check if 'cos-prometheus' is from another model
2023-08-30 12:14:08 [WARNING] Multi-model is not supported yet. Please check if 'cos-grafana' is from another model
2023-08-30 12:14:08 [WARNING] Multi-model is not supported yet. Please check if 'cos-loki' is from another model
2023-08-30 12:14:08 [WARNING] Multi-model is not supported yet. Please check if 'cos-prometheus' is from another model
~~~~~~~

There are several issues that we need to fix in the bundle, but towards the end it complains about not having any lma charms, not recognizing cos-proxy, and not recognizing the cos charms. The expected behaviour is that juju-lint does a check for either lma or cos, and adjusts the rules based on what it finds.

To avoid duplicate cmr names when using both lma and cos in the same bundle, we renamed the cmr applications to `{model_name}-{application_name}`. It would be nice if juju-lint could check the charm name rather than the application name to accommodate for this.