The "prev" and "next" navigation buttons in carousels are not translated.

Bug #2033067 reported by Eva Cerninakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.10
Fix Released
Medium
Unassigned
3.11
Fix Released
Medium
Unassigned

Bug Description

The "prev" and "next" navigation buttons in carousels are not translated.
I guess it is due to lines 852 - 853 in Open-ILS/src/templates/opac/parts/misc_util.tt2 has not been marked for translation:

  <button class="glide__arrow glide__arrow--left" data-glide-dir="<">
prev</button>
  <button class="glide__arrow glide__arrow--right" data-glide-dir=">">next</button>

I used Blake's test server with the Czech localization (https://bugsquash3.mobiusconsortium.org/eg2/cs-CZ/staff/catalog) for testing.

Revision history for this message
Eva Cerninakova (ece) wrote :
tags: added: i18n
Changed in evergreen:
status: New → Confirmed
Steven Mayo (stmayo)
Changed in evergreen:
assignee: nobody → Steven Mayo (stmayo)
Revision history for this message
Steven Mayo (stmayo) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Steven Mayo (stmayo) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Confirmed on a docker container with cs-CZ support:
* The next button on carousels now says "Další"
* After `cd build/i18n && make newpot && make LOCALE=cs-CZ updatepo`, po/bootstrap-opac/cs-CZ.po has the "Prev" string ready to be translated
* After adding the translation "Předchozí" to po/tpac/cs-CZ.po, I can `make LOCALE=cs-CZ install && cd ../.. && make install && apache2ctl restart`, and the carousel "Prev" button now says "Předchozí".

Thanks, Steven! Signoff branch at user/sandbergja/lp2033067-Carousel_Buttons_i18n-signoff

tags: added: signedoff
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.12-beta
importance: Undecided → Medium
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Steven & Jane! Fix committed back to 3.10

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.