OSC operations that have optional params don't raise an error when no options are passed

[Goutham Pacha Ravi]

This is a UX improvement RFE.

When using the OSC CLI, when a command has optional parameters, not providing any of these options doesn't currently raise any errors.

For example:

https://opendev.org/openstack/python-manilaclient/src/commit/7a15a2a1ae9bde8236547b85c90a9f71c9f11073/manilaclient/osc/v2/security_services.py#L280-L323

Here, if you use:

 $ openstack share security service set mysecservice

i.e, you specify the pos arg in this case (Security service name or ID) but not any of the optional args, the command does nothing. This pattern exists elsewhere too.

It'd be nice for the CLI to suggest that one or more of the options are necessary to have an effect; perhaps as a warning log?

[Solomon Barine Akpuru (solly47)]

Hi Goutham, could you assign this bug to me?

[Goutham Pacha Ravi (gouthamr)]

> Hi Goutham, could you assign this bug to me?

Hi Solomon,

Thank you for your interest here. Please propose a bug fix, and i'll set the asignee field.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/913443

[Takashi Kajinami (kajinamit)]

I've checked a few commands in openstackclient and many existing commands do not fail when the commands have only optional options and no option is passed.

eg.
 $ openstack server set <servername>
 $ openstack network set <network name>
 $ openstack subnet set <subnet name>

So the current behavior follows the standard. If we change this then we should make this change consistently across all openstack commands but I don't think it's worth paying effort to, atm