Drop compile support for stock / regular MinGW
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DC++ |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Follow up to https:/
[2023-08-21 16:27] <cologic> I thought some parts of DC++ specifically tried to detect and error on stock MinGW
[2023-08-21 16:28] <eMTee> Well, the wording in compile.txt does not seem to tell that. At least in my interpretation.
[2023-08-21 16:29] <cologic> https:/
[2023-08-21 16:32] <eMTee> https:/
[2023-08-21 16:33] <cologic> so either compiler.h is too strict or Compile.txt omits important information
[2023-08-21 16:33] <eMTee> "install compilers from regular MinGW " and so on...
[2023-08-21 16:34] <cologic> but would current stock MinGW have the same problem as https:/
[2023-08-21 16:35] <cologic> it's worth figuring this out a bit, because if working on stock MinGW is important, then the change still has to account for it
[2023-08-21 16:35] <cologic> but if it's not, that does simplify things
[2023-08-22 10:24] <eMTee> Hm. https:/
[2023-08-22 10:27] <eMTee> Actually it seems so. Both websites listed here, old and new, (mingw.org / osdn.net/
[2023-08-22 10:30] <eMTee> There is https:/
[2023-08-22 10:38] <eMTee> And it is actually a mingw-w64 fork: "MinGW's official website mingw-w64.org provides various builds, but I maintain my own distro because I demand complete control. (It's a long story, but mingw-w64 forked from mingw.org. Although my distro was based on mingw.org for many years, I now consider mingw-w64 to be the one true MinGW.)"
[2023-08-22 10:40] <eMTee> Same as https:/
[2023-08-22 10:48] <eMTee> Versions still available in https:/
[2023-08-22 10:55] <eMTee> https:/
[2023-08-22 14:35] <cologic> So, not worth supporting, or?
[2023-08-22 14:39] <eMTee> We haven't been supporting it in the last 11 years (for Windows). Perhaps enabling it with a warning that tells it is untested and update the docs accordingly.
[2023-08-22 14:41] <eMTee> The latest release from 2021 may or may not fixed the issues we had back then. But we can't even test it now since the latest mingw-get cannot be downloaded and if it had been then most probably couldn't access the packages needed to install.
[2023-08-22 14:45] <eMTee> Or, yeah, remove it from the list of supported compilers in the docs, according to what it's been like for 11 years.
<cologic> Let's drop support (basically, even if currently it kind of works if one removes the #error in the .h file, it's apparently going to just decay from there)
<cologic> if we'd already been supporting it, then, sure, keep support until it breaks. but as is, not worth adding any more checking
<eMTee> yeah I agree, looks like mingw-w64 and the wide variety of its forks will supply a quality and up to date compiler for the foreseeable future.
<cologic> Yeah, if one wants to try/support another compiler, then clang/llvm as iceman50 has discussed would be interesting, if mingw-w64 ever falters on Windows
<iceman50> +1 to what cologic said
<iceman50> it's only going to get worse and not better IMHO keeping the stock MinGW
summary: |
- Drop compile support for stock / regular MinGW for Windows + Drop compile support for stock / regular MinGW |
Changed in dcplusplus: | |
status: | New → Fix Committed |
Fixed in DC++ 0.881