Missing None check for CluesterIP on Instantiation

Bug #2032870 reported by Kenta Fukaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Undecided
Ken Fujimoto

Bug Description

Checking if ClusterIP is None by '' or None[1].
Missing None check, if CluesterIP's value is "None"(String type).

'''
    if service_info.spec.cluster_ip in ['', None] or _check_is_ip(
                service_info.spec.cluster_ip):
'''

[1] https://github.com/openstack/tacker/blob/0becf595f42c35bc32d498ba40a4e7bc4b136343/tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py#L312

Changed in tacker:
assignee: nobody → Ken Fujimoto (k-fujimoto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/893136

Changed in tacker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.opendev.org/c/openstack/tacker/+/893136
Committed: https://opendev.org/openstack/tacker/commit/8e489dc382124f9f2a26acaf37e2feab94c57ac6
Submitter: "Zuul (22348)"
Branch: master

commit 8e489dc382124f9f2a26acaf37e2feab94c57ac6
Author: Ken Fujimoto <email address hidden>
Date: Wed Aug 23 08:48:44 2023 +0000

    Fix status check of k8s resources

    This patch fixes the following k8s resource status check problems
    in CNF v1/v2 API.
    * Fix resource availability check failure when volumeClaimTemplates
      is not used in StatefulSet.
    * Fix a problem that resource availability check does not get status
      correctly when the ClusterIP of Service is not set.

    Closes-Bug: #2032867
    Closes-Bug: #2032870
    Change-Id: I0587c31a7c020b3e5d57f07fef902783464b0abe

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 10.0.0.0rc1

This issue was fixed in the openstack/tacker 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.