The charm exposes no-op options to operators

Bug #2032869 reported by Nobuto Murata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Manila-Ganesha Charm
Fix Committed
Undecided
Unassigned

Bug Description

The manila-ganesha inherits layer:openstack-api on purpose even though it doesn't offer any sort of OpenStack API service.

src/layer.yaml already has the following section not to expose OpenStack API related config options to operators:

config:
  deletes:
    - region
    - ssl_ca
    - ssl_cert
    - ssl_key

However, there are more no-op options exposed namely:

    - haproxy-server-timeout
    - haproxy-client-timeout
    - haproxy-queue-timeout
    - haproxy-connect-timeout
    - dns-ha
    - os-admin-hostname
    - os-admin-network
    - os-internal-hostname
    - os-internal-network
    - os-public-hostname
    - os-public-network

We can avoid confusions by hiding those no-op options.

Nobuto Murata (nobuto)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila-ganesha (master)
Changed in charm-manila-ganesha:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila-ganesha (master)

Reviewed: https://review.opendev.org/c/openstack/charm-manila-ganesha/+/892634
Committed: https://opendev.org/openstack/charm-manila-ganesha/commit/e46a056636e243940e04f63b5fc068caf2b2ddff
Submitter: "Zuul (22348)"
Branch: master

commit e46a056636e243940e04f63b5fc068caf2b2ddff
Author: Nobuto Murata <email address hidden>
Date: Thu Aug 24 11:36:04 2023 +0900

    Don't expose no-op options for OpenStack API service

    Manila-ganesha inherits layer:openstack-api on purpose to configure the
    manila-share and related services, but the units won't have OpenStack
    API endpoints by nature. We already have some config options excluded in
    layers.yaml but we should extend the list to exclude more no-op options
    related to OpenStack APIs so we can avoid confusing operators.

    Closes-Bug: #2032869
    Change-Id: Ic6dc3887bc3ca31e32acf81f7a0b6e6e3e73ba1c

Changed in charm-manila-ganesha:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.