Create MARC Record - Hide help button for flat editor

Bug #2031123 reported by Josh Stompro
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.10
Fix Released
Medium
Unassigned

Bug Description

Testing on EG 3.11

In the Create MARC Record interface the help button doesn't do anything in the flat text editor. Hide it when the flat text editor is selected.

Breaking out the various chunks from bug #1862235 to keep all of them from being held up by issues with only certain ones.

Ugh, forgot to add release notes... will go back and do that.

Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Working branch at user/stompro/lp2031123_create_marc_hide_help_flat

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp2031123_create_marc_hide_help_flat

Tested on 3.11 system. Release note included.

Testing Notes:

Related to the Create MARC Record interface.

Before the fix: The help button is displayed when the flat text editor is open, even through it doesn't have any effect when clicked. The Help text is only for the regular editor.

After the fix: The help button is hidden when the flat text editor is enabled, and shows back up when the flat text editor is disabled.

Josh

tags: added: pullrequest
Beth Willis (willis-a)
Changed in evergreen:
status: New → Confirmed
tags: added: cataloging
Revision history for this message
Beth Willis (willis-a) wrote :

Tested on Terran's test server.

This code works exactly as described. The "Help" button does not display in the flat text editor. Cleaning up interfaces in this way is great and helps to eliminate confusion.

I have tested this code and consent to signing off on it with my name, Beth Willis and my email address, willis@noblenet

Michele Morgan (mmorgan)
tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

These keyboard shortcuts are great accessibility improvements to the MARC editor. Pushed to main and rel_3_11. There were merge conflicts in rel_3_10 so they have not been pushed there.

Thanks Josh and Beth!

Changed in evergreen:
importance: Undecided → Medium
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
milestone: none → 3.11.2
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.