[MIR] promote libdbix-simple-perl as a libmail-dmarc-perl dependency

[Miriam España Acebal]

[Availability]
The package libdbix-simple-perl is already in Ubuntu universe.
The package libdbix-simple-perl build for the architectures it is designed to work on.
It currently builds and works for architectures: amd64
Link to package https://launchpad.net/ubuntu/+source/libdbix-simple-perl

[Rationale]
The package libdbix-simple-perl is required in Ubuntu main for libmail-dmarc-perl.
The package libdbix-simple-perl will not generally be useful for
a large part of our user base, but is important/helpful still
because libmail-dmarc-perl requires it as a runtime dependency
( libmail-dmarc-perl is in the MIR process here: https://bugs.launchpad.net/ubuntu/+source/libmail-dmarc-perl/+bug/2023971 )

The package libdbix-simple-perl is required in Ubuntu main through the same scheduled requested
for the libmail-dmarc-perl promotion, since libmail-dmarc-perl depends on it.

[Security]
No CVEs/security issues in this software in the past.
No `suid` or `sgid` binaries.
No executables in `/sbin` and `/usr/sbin`.
Package does not install services, timers or recurring jobs.
Package does not open privileged ports (ports < 1024).
Package does not expose any external endpoints.
Package does not contain extensions to security-sensitive software (filters, scanners, plugins, UI skins, ...).

[Quality assurance - function/usage]
The package works well right after install.

[Quality assurance - maintenance]
The package is maintained well in Debian/Ubuntu/Upstream and does
not have critical/long term open bugs in Ubunto nor in Debian:
  - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libdbix-simple-perl/+bug (total 0)
  - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libdbix-simple-perl (total 0)
  - Upstream https://rt.cpan.org/Public/Dist/Display.html?Name=DBIx-Simple (total 9)
The package has important/old open bugs on upstream , listing them:
  - https://rt.cpan.org/Ticket/Display.html?id=66228 : Please provide clear licensing terms -> This seems previous to the Debian packaging work
The package does not deal with exotic hardware we cannot support.

[Quality assurance - testing]
The package runs a test suite on build time, if it fails
it makes the build fail: https://launchpadlibrarian.net/606956569/buildlog_ubuntu-kinetic-amd64.libdbix-simple-perl_1.37-2_BUILDING.txt.gz :
   dh_auto_test
 make -j4 test TEST_VERBOSE=1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" t/*.t
t/DBIx-Simple.t ..

The package runs an autopkgtest (via autodep8 using 'Testsuite: autopkgtest-pkg-perl' in d/control file ), which essentially runs the above build-time test suite. It's currently passing on
this list of architectures (amd64, arm64, armhf, ppc64el, riscv64, s390x), except on i386 since focal:
https://autopkgtest.ubuntu.com/packages/l/libdbix-simple-perl

[Quality assurance - packaging]
debian/watch is present and works

debian/control defines a correct Maintainer field: Debian Perl Group <email address hidden>

This package does not yield massive lintian Warnings, Errors
  - recent build log of the package: https://launchpadlibrarian.net/606956569/buildlog_ubuntu-kinetic-amd64.libdbix-simple-perl_1.37-2_BUILDING.txt.gz
  - full output from `lintian --pedantic` :
    #source
    ❯ lintian -EvIL +pedantic --show-overrides
      E: libdbix-simple-perl changes: bad-distribution-in-changes-file mantic
      W: libdbix-simple-perl: changelog-distribution-does-not-match-changes-file (unstable != mantic)
      W: libdbix-simple-perl changes: distribution-and-changes-mismatch mantic unstable
    #binary
    ❯ lintian -EvIL +pedantic --show-overrides ../libdbix-simple-perl_1.37-2.dsc
      I: libdbix-simple-perl source: out-of-date-standards-version 4.1.3 (released 2017-12-27) (current is 4.6.0.1)
      X: libdbix-simple-perl source: debian-watch-does-not-check-gpg-signature [debian/watch]
      P: libdbix-simple-perl source: silent-on-rules-requiring-root [debian/control]
      P: libdbix-simple-perl source: update-debian-copyright 2018 vs 2022 [debian/copyright:11]
      X: libdbix-simple-perl source: upstream-metadata-file-is-missing
  - Lintian overrides are not present

This package does not rely on obsolete or about to be demoted packages.
This package has no python2 or GTK2 dependencies.

The package will not be installed by default.

Packaging and build is easy, link to debian/rules : https://git.launchpad.net/ubuntu/+source/libdbix-simple-perl/tree/debian/rules?h=ubuntu/mantic-devel

[UI standards]
Application is not end-user facing (does not need translation).

[Dependencies]
- No further depends dependencies that are not yet in main
- This has Recommends on three universe packages: libobject-accessor-perl, libsql-abstract-perl, libtext-table-perl. Checking recursive binary dependencies:
  - libobject-accesor-perl: No further depends or recommends dependencies that are not yet in main.

  - libsql-abstract-perl : Depends on universe package libhash-merge-perl, and recommends two universe packages: libtest-deep-perl and libtest-simple-perl
    - libhash-merge-perl: Depends on universe packaga libclone-choose-perl
      - libclone-choose-perl: Recommends universe package libclone-pp-perl.
        - libclone-pp-perl: No further depends or recommends dependencies that are not yet in main.
    - libtest-deep-perl: Depends on two universe packages: libscalar-list-utils-perl and libtest-simple-perl.
      - libscalar-list-utils-perl : No further depends or recommends dependencies that are not yet in main.
      - libtest-simple-perl: No further depends or recommends dependencies that are not yet in main.
    - libtest-simple-perl: No further depends or recommends dependencies that are not yet in main.

  - libtext-table-perl: Depends on universe package libtext-aligner-perl.
    - libtext-aligner-perl: No further depends or recommends dependencies that are not yet in main.

  Instead of MIR the above, an option that may be worthwhile would be to move the initial Recommends to Suggests.

[Standards compliance]
This package correctly follows FHS and Debian Policy (4.1.3.).

[Maintenance/Owner]
Owning Team will be Ubuntu Server Team.
Team is not yet, but will subscribe to the package before promotion.

This does not use static builds.
This does not use vendored code
This package is not rust based

The package successfully built during the most recent test rebuild: https://launchpad.net/ubuntu/+archive/test-rebuild-20230515-lunar-v3/+build/26135205/+files/buildlog_ubuntu-lunar-amd64.libdbix-simple-perl_1.37-2_BUILDING.txt.gz

[Background information]
The Package description explains the package well
Upstream Name is DBIx-Simple
Link to upstream project https://metacpan.org/dist/DBIx-Simple

This has been in the archive since at least 2013. It's never had a bug filed against it in Launchpad, except one sync request to update it in 2017.

[Lukas Märdian (slyon)]

Review for Source Package: libdbix-simple-perl

[Summary]
This is a higher level abstraction layer to Perl's SQL/database wrapper (libdbi-perl).

MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.

This does not need a security review

List of specific binary packages to be promoted to main: libdbix-simple-perl
Specific binary packages built, but NOT to be promoted to main: None

Notes:
- It passes through SQL statements to the DBI layer from trusted source code,
  so I don't feel like this needs security review.

Required TODOs:
#1 other Dependencies to MIR due to this:
 * libobject-accessor-perl binary and source package is in universe
 * libsql-abstract-perl binary and source package is in universe
 * libtext-table-perl binary and source package is in universe

Recommended TODOs:
#2 The package should get a team bug subscriber before being promoted
#3 Upstream & Debian/Ubuntu update history is sporadic
=> Maybe we can do a better job of at least packaging new versions in a timely
   manner, once this is in main. There are not too frequent releases upstream.
#4 Lintian hints, which might be worth looking at:
I: libdbix-simple-perl source: out-of-date-standards-version 4.1.3 (released 2017-12-27) (current is 4.6.2)
P: libdbix-simple-perl source: silent-on-rules-requiring-root [debian/control]
X: libdbix-simple-perl source: upstream-metadata-file-is-missing

[Duplication]
There is no other package in main providing the same functionality.

Some potential duplicates are listed in the command below, most of them in
universe, except libdbi-perl, which is being used by libdbix-simple-perl as
a lower-layer abstraction.
$ rmadison -c main -s mantic {libdbix-abstract-perl,libsql-abstract-perl,libdbix-class-perl,libdbix-easy-perl,libdbix-oo-perl,libdbix-safe-perl,libdbi-perl}
 libdbi-perl | 1.643-4 | mantic | source, amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems:
- other Dependencies to MIR due to this:
 * libobject-accessor-perl binary and source package is in universe
 * libsql-abstract-perl binary and source package is in universe
 * libtext-table-perl binary and source package is in universe

[Embedded sources and static linking]
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source. (passing through SQL from trusted source code)
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary ...

[Lukas Märdian (slyon)]

Moving to "In Progress", as we're just waiting on a few dependency MIRs.

Those dependencies are "just" Recommends. You can also consider dropping them to unlock the MIR.