Import GTK Dialog doesn't handle multiple files

[esjay]

Hi. I use subversion built on Ubuntu Gutsy 7.10.
The version is "Inkscape 0.45+devel, built Mar 15 2008", according to "Help > About Inkscape"

Inkscape can import multiple files successfully by drag and drop from certain filers, however, by its own import dialog, it can import only one file.
The selection area looks as if it can handle multiple ones, but actually it always imports just the first file.

[prkos (prkos)]

I can confirm on WinXP, only here you cant select multiple files in the import dialog, holding Ctrl does nothing, the first selected file gets imported immediately

[prkos (prkos)]

marked the older one as a duplicate as the new one contains up to date info

[su_v (suv-lp)]

Reverting duplicate status (Bug #220000 “Open dialog multiple select not working”) because while it works in the 'Open' dialog, it fails to import multiple selected files from the 'Import' dialog.

[su_v (suv-lp)]

Reproduced with Inkscape 0.48 and 0.48+devel r9737 on OS X 10.5.8

'File > Open…' allows to open multiple selected files, but 'File > Import…' only imports the first of multiple selected files.

[heisenbug (ggreif-gmail)]

Okay, here is a patch to fix this. It is modeled after the "open" dialog's way of doing things. I do not have bzr at hand now, so the patch is against last SVN trunk, but should apply anyway. Disclaimer: 100% untested, may not even compile - but is close!

[su_v (suv-lp)]

Patch tested with Inkscape 0.48+devel r9737 on OS X 10.5.8

First tests look good - imports without apparent failure:
- multiple files of the same file type (PNG, PDF, SVG)
- mix of different file types (PDF, PNG, DXF)

Needs code review and testing on other platforms.

[jazzynico (jazzynico)]

Patch tested successfully on Ubuntu 10.04, Inkscape trunk revision 9742. Same tests as in comment #6.

[heisenbug (ggreif-gmail)]

whom should I ping, so that it ends up on the (preferably) 0.48.x branch? 0.49.x is also OK if mandated by the development process...

[Jon A. Cruz (jon-joncruz)]

Did a quick review. There are a few structural issues that will need cleanup before committing, but the general direction looks good. I'll probably have more time to poke at this over the week.

[heisenbug (ggreif-gmail)]

Any progress with this bug? I am asking, because my wife (a graphical artist) is considering this as the single, most annoying misfeature of inkscape and would have already switched to Illustrator if I weren't holding her back, pointing to the included patch :-/

[su_v (suv-lp)]

No regressions noted while using the patch as is with current trunk on Mac OS X 10.5.8 (i386) for several months now (though I mostly import individual files). As far as I know there have been not tests done on Windows yet.

@JonCruz - any chance the patch can be reviewed in time to get included in the next bug-fix release?

[ScislaC (scislac)]

Patch appeared okay to me, if Jon wants to fix structural issues he can do so in trunk as of r11081. :)