igc ethernet driver: unplugging thunderbolt dock causes kernel OOPs

[Alberto Donato]

I have a ThinkPad Thunderbolt 4 dock.

When I unplug it from the laptop, I see this traceback in kernel logs:

[407643.532144] igc 0000:79:00.0 enp121s0: PCIe link lost, device now detached
[407643.532174] ------------[ cut here ]------------
[407643.532179] igc: Failed to read reg 0x5b50!
[407643.532367] WARNING: CPU: 4 PID: 598295 at drivers/net/ethernet/intel/igc/igc_main.c:6412 igc_rd32+0xa4/0xc0 [igc]
[407643.532430] Modules linked in: tcp_diag inet_diag xt_nat nf_conntrack_netlink 8021q garp mrp veth nft_masq zfs(PO) zunicode(PO) zzstd(O) zlua(O) zavl(PO) icp(PO) zcommon(PO) znvpair(PO) spl(O) vhost_vsock vmw_vsock_virtio_transport_common vhost vhost_iotlb vsock xfrm_user xfrm_algo xt_addrtype ccm rfcomm snd_seq_dummy snd_hrtimer xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink cmac algif_hash algif_skcipher af_alg bnep binfmt_misc nls_iso8859_1 snd_ctl_led snd_soc_skl_hda_dsp snd_soc_intel_hda_dsp_common snd_soc_hdac_hdmi snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_intel_hda snd_sof_pci snd_sof_xtensa_dsp snd_sof snd_sof_utils snd_soc_hdac_hda snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi
[407643.532614] soundwire_bus snd_soc_core snd_compress ac97_bus snd_pcm_dmaengine intel_tcc_cooling iwlmvm x86_pkg_temp_thermal intel_powerclamp snd_hda_intel coretemp snd_intel_dspcfg mac80211 kvm_intel snd_intel_sdw_acpi btusb pmt_telemetry mei_pxp mei_hdcp btrtl intel_rapl_msr pmt_class libarc4 snd_hda_codec kvm snd_usb_audio uvcvideo snd_seq_midi btbcm snd_seq_midi_event snd_usbmidi_lib videobuf2_vmalloc snd_hda_core btintel videobuf2_memops snd_hwdep btmtk snd_rawmidi videobuf2_v4l2 irqbypass snd_seq iwlwifi bluetooth processor_thermal_device_pci videodev processor_thermal_device snd_pcm mei_me processor_thermal_rfim rapl snd_seq_device videobuf2_common think_lmi processor_thermal_mbox spi_nor thinkpad_acpi processor_thermal_rapl ucsi_acpi intel_cstate ecdh_generic firmware_attributes_class wmi_bmof typec_ucsi nvram cfg80211 mtd snd_timer mei ecc mc joydev intel_vsec intel_rapl_common igen6_edac typec snd soundcore nxp_nci_i2c ledtrig_audio int3403_thermal platform_profile nxp_nci
[407643.532800] int340x_thermal_zone nci nfc int3400_thermal intel_hid acpi_thermal_rel acpi_tad sparse_keymap acpi_pad input_leds hid_multitouch serio_raw mac_hid overlay iptable_filter ip6table_filter ip6_tables br_netfilter bridge stp llc arp_tables msr parport_pc ppdev lp parport efi_pstore dmi_sysfs ip_tables x_tables autofs4 btrfs blake2b_generic xor raid6_pq libcrc32c dm_crypt hid_lenovo usbhid i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper syscopyarea hid_generic sysfillrect crct10dif_pclmul crc32_pclmul polyval_clmulni polyval_generic ghash_clmulni_intel sha512_ssse3 aesni_intel nvme crypto_simd sysimgblt nvme_core psmouse cryptd drm e1000e igc thunderbolt spi_intel_pci intel_lpss_pci i2c_i801 spi_intel xhci_pci intel_lpss i2c_smbus idma64 xhci_pci_renesas nvme_common i2c_hid_acpi i2c_hid video hid wmi pinctrl_tigerlake
[407643.532992] CPU: 4 PID: 598295 Comm: kworker/4:7 Tainted: P O 6.2.0-26-generic #26-Ubuntu
[407643.533005] Hardware name: LENOVO 21AHCTO1WW/21AHCTO1WW, BIOS N3MET15W (1.14 ) 04/27/2023
[407643.533012] Workqueue: events igc_watchdog_task [igc]
[407643.533062] RIP: 0010:igc_rd32+0xa4/0xc0 [igc]
[407643.533103] Code: c7 c6 d8 55 4c c0 e8 cb b9 71 e9 48 8b bb 28 ff ff ff e8 df 1b 23 e9 84 c0 74 b4 44 89 e6 48 c7 c7 00 56 4c c0 e8 6c 9a a3 e8 <0f> 0b eb a1 b8 ff ff ff ff 31 d2 31 f6 31 ff c3 cc cc cc cc 0f 1f
[407643.533113] RSP: 0018:ffffa8da031d7c90 EFLAGS: 00010246
[407643.533122] RAX: 0000000000000000 RBX: ffff9d99501b8c60 RCX: 0000000000000000
[407643.533129] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[407643.533133] RBP: ffffa8da031d7ca8 R08: 0000000000000000 R09: 0000000000000000
[407643.533138] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000005b50
[407643.533143] R13: ffff9d99501b8000 R14: 0000000000020002 R15: 0000000000000002
[407643.533149] FS: 0000000000000000(0000) GS:ffff9da36f500000(0000) knlGS:0000000000000000
[407643.533156] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[407643.533162] CR2: 00000d3cd5265000 CR3: 0000000706210000 CR4: 0000000000750ee0
[407643.533170] PKRU: 55555554
[407643.533174] Call Trace:
[407643.533180] <TASK>
[407643.533190] igc_get_hw_semaphore_i225+0x4e/0x190 [igc]
[407643.533233] igc_acquire_swfw_sync_i225+0x5e/0xd0 [igc]
[407643.533267] igc_acquire_phy_base+0x14/0x30 [igc]
[407643.533302] igc_read_phy_reg_gpy+0x34/0xf0 [igc]
[407643.533341] igc_phy_has_link+0x94/0x170 [igc]
[407643.533377] igc_check_for_copper_link+0x98/0x160 [igc]
[407643.533412] igc_has_link+0x40/0xb0 [igc]
[407643.533445] igc_watchdog_task+0x44/0x570 [igc]
[407643.533479] process_one_work+0x222/0x430
[407643.533493] worker_thread+0x50/0x3e0
[407643.533502] ? __pfx_worker_thread+0x10/0x10
[407643.533511] kthread+0xe6/0x110
[407643.533524] ? __pfx_kthread+0x10/0x10
[407643.533535] ret_from_fork+0x29/0x50
[407643.533547] </TASK>
[407643.533550] ---[ end trace 0000000000000000 ]---

Note that the dock ethernet port was not in use when the dock was unplugged.

I've seen this error multiple times on disconnect

ProblemType: Bug
DistroRelease: Ubuntu 23.04
Package: linux-image-6.2.0-26-generic 6.2.0-26.26
ProcVersionSignature: Ubuntu 6.2.0-26.26-generic 6.2.13
Uname: Linux 6.2.0-26-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.26.1-0ubuntu2
Architecture: amd64
CRDA: N/A
CasperMD5CheckResult: pass
CurrentDesktop: GNOME
Date: Sat Jul 29 13:13:19 2023
InstallationDate: Installed on 2023-04-07 (112 days ago)
InstallationMedia: Ubuntu 23.04 "Lunar Lobster" - Daily amd64 (20230402)
MachineType: LENOVO 21AHCTO1WW
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-6.2.0-26-generic root=UUID=77d67dcd-a70a-4ee7-be9d-00c2cf6248c2 ro rootflags=subvol=@ quiet splash vt.handoff=7
RelatedPackageVersions:
 linux-restricted-modules-6.2.0-26-generic N/A
 linux-backports-modules-6.2.0-26-generic N/A
 linux-firmware 20230323.gitbcdcfbcf-0ubuntu1.2
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 04/27/2023
dmi.bios.release: 1.14
dmi.bios.vendor: LENOVO
dmi.bios.version: N3MET15W (1.14 )
dmi.board.asset.tag: Not Available
dmi.board.name: 21AHCTO1WW
dmi.board.vendor: LENOVO
dmi.board.version: Not Defined
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.ec.firmware.release: 1.8
dmi.modalias: dmi:bvnLENOVO:bvrN3MET15W(1.14):bd04/27/2023:br1.14:efr1.8:svnLENOVO:pn21AHCTO1WW:pvrThinkPadT14Gen3:rvnLENOVO:rn21AHCTO1WW:rvrNotDefined:cvnLENOVO:ct10:cvrNone:skuLENOVO_MT_21AH_BU_Think_FM_ThinkPadT14Gen3:
dmi.product.family: ThinkPad T14 Gen 3
dmi.product.name: 21AHCTO1WW
dmi.product.sku: LENOVO_MT_21AH_BU_Think_FM_ThinkPad T14 Gen 3
dmi.product.version: ThinkPad T14 Gen 3
dmi.sys.vendor: LENOVO

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[Lassi Väätämöinen (lvaatamoinen)]

Occurred today on KDE Neon, while plugging the TB4 dock. This started happening after the recent updates, so was working fine reboot today.

[ 7556.301991] usb 3-5.1: Product: ThinkPad Thunderbolt 4 Dock MCU Contoller
[ 7556.301992] usb 3-5.1: Manufacturer: Lenovo
[ 7556.301993] usb 3-5.1: SerialNumber: 0123456789ABCDEF
[ 7556.309244] hid-generic 0003:17EF:30B4.0010: hiddev2,hidraw7: USB HID v1.11 Device [Lenovo ThinkPad Thunderbolt 4 Dock MCU Contoller] on usb-0000:00:14.0-5.1/input0
[ 7556.981411] igc 0000:49:00.0 enp73s0: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
[ 7556.981648] IPv6: ADDRCONF(NETDEV_CHANGE): enp73s0: link becomes ready
[ 7557.130669] igc 0000:49:00.0 enp73s0: PCIe link lost, device now detached
[ 7557.130677] ------------[ cut here ]------------
[ 7557.130678] igc: Failed to read reg 0xc030!
[ 7557.130690] WARNING: CPU: 13 PID: 1735 at drivers/net/ethernet/intel/igc/igc_main.c:6412 igc_rd32+0xaf/0xc0 [igc]
[ 7557.130701] Modules linked in: igc ccm rfcomm xt_conntrack nft_chain_nat xt_MASQUERADE nf_nat nf_conntrack_netlink nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 xfrm_user xfrm_algo xt_addrtype br_netfilter bridge stp llc vboxnetadp(O) vboxnetflt(O) vboxdrv(O) xt_comment nft_compat nf_tables nfnetlink cmac algif_hash algif_skcipher af_alg overlay bnep binfmt_misc dm_crypt nvidia_uvm(PO) nvidia_drm(PO) nvidia_modeset(PO) intel_tcc_cooling x86_pkg_temp_thermal intel_powerclamp coretemp snd_ctl_led snd_soc_skl_hda_dsp kvm_intel snd_soc_intel_hda_dsp_common snd_soc_hdac_hdmi snd_sof_probes kvm nvidia(PO) irqbypass snd_hda_codec_realtek snd_hda_codec_generic snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_intel_hda snd_sof_pci snd_sof_xtensa_dsp snd_sof snd_sof_utils snd_soc_hdac_hda snd_hda_ext_core snd_soc_acpi_intel_match snd_soc_acpi soundwire_bus snd_soc_core snd_compress ac97_bus nls_iso8859_1
[ 7557.130735] snd_hda_codec_hdmi snd_pcm_dmaengine rapl iwlmvm btusb snd_hda_intel btrtl snd_intel_dspcfg btbcm snd_usb_audio mac80211 snd_intel_sdw_acpi btintel uvcvideo snd_usbmidi_lib snd_hda_codec btmtk videobuf2_vmalloc snd_seq_midi libarc4 mei_hdcp processor_thermal_device_pci_legacy mei_pxp snd_seq_midi_event videobuf2_memops cmdlinepart snd_hda_core bluetooth intel_rapl_msr processor_thermal_device snd_rawmidi snd_seq iwlwifi videobuf2_v4l2 spi_nor snd_hwdep think_lmi processor_thermal_rfim thinkpad_acpi ecdh_generic snd_seq_device intel_cstate serio_raw videodev snd_pcm joydev mtd firmware_attributes_class input_leds videobuf2_common cfg80211 processor_thermal_mbox wmi_bmof ee1004 nvram mc ecc snd_timer mei_me processor_thermal_rapl mei snd intel_rapl_common ledtrig_audio soundcore intel_soc_dts_iosf int3403_thermal int3400_thermal platform_profile intel_hid int340x_thermal_zone acpi_thermal_rel mac_hid acpi_pad acpi_tad sparse_keymap sch_fq_codel vcan can_dev msr parport_pc
[ 7557.130769] ppdev lp parport efi_pstore ip_tables x_tables autofs4 btrfs blake2b_generic xor raid6_pq libcrc32c hid_logitech_hidpp hid_logitech_dj hid_generic usbhid hid i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core crct10dif_pclmul...

[Lassi Väätämöinen (lvaatamoinen)]

I could not pin-point a specific upgrade that could cause this. The previous batch of updates contained pretty much just
- KDE and Qt updates
- fwupd libflashrom1

Last time I saw this, I was using 5.19 kernel, and it was said that a fix was in 6.0. or newer.
Now I have run 6.2.0-33 for 3 months without issues, until today, as this happens continuously right upon connecting the TB4 dock.