nova evacaute action will destroy the vm if the vm is migrate back but the migration it not completed

[efineshi]

for example:
1. the compte node's network is disconnected。the compute lost connection to the controller and it was down.
2. evacuted the servers from the the failed compute node. and manual distroy all the servers in the node.
3. the compute node's network is reconected。
4. we migrate the servers back to compute node.
5. restert the nova-compute, the servers will be destroy cause of the migration action is not completed before and it think the servers are dirty.

[Uggla (rene-ribaud)]

Thanks for submitting this bug, but it is incomplete and can not be treated without the following information. Please add them to the ticket.

- steps to reproduce
- the version of Nova and the novaclient (or os-client)
- logs (on debug level)
- environment details depending on the bug
        libvirt/kvm versions, VMWare version, ...
        storage type (ceph, LVM, GPFS, ...)
        network type (nova-network or neutron)

For bug reporting assistance, use OpenStack's Bug template available at: https://wiki.openstack.org/wiki/Nova/BugsTeam/BugReportTemplate.

[efineshi (efineshi)]

- Steps to reproduce
   ==================
1. the compte node's network is disconnected。the compute lost connection to the controller and it was down.
2. evacuted the servers from the the failed compute node. and manual distroy all the servers in the node.
3. the compute node's network is reconected。
4. we migrate the servers back to compute node.
5. restert the nova-compute, the servers will be destroy cause of the migration action is not completed before and it think the servers are dirty.

- the version of Nova and the novaclient (or os-client)
   ==================
I noticed it on Ocata, and I tested it on the master branch, the problem is still exists. it affect all the branchs.

- logs
the logs on ocata is:
  "Deleting instance as it has been evacuated from this host"
and on the master branch is:
  "Destroying instance as it has been evacuated from this host but still exists in the hypervisor"

- environment details
   ==================
this bug not depends on any kvm version. it it a logical error for nova-compute.

this is my patch for it, and I tested it in my environment, it works.

https://review.opendev.org/c/openstack/nova/+/887564