Shelving location ID 1 cannot be modified

[Galen Charlton]

It is impossible to make changes to the shelving location whose ID is 1, e.g., to rename it from 'Stacks' or to change its OPAC visibility. (Short of direct SQL to disable the protect_acl_id_1 rule.)

This is because the patch for bug 827356 went a little too far: while asset.copy_location ID = 1 should never be removed (and perhaps should never have its owner be anything other than the root of the OU hierarchy), there's no functional reasons why other changes to that location should be blocked.

This bug was originally reported by pdinc-support here: https://bugs.launchpad.net/evergreen/+bug/827356/comments/13

[Jason Boyer (jboyer)]

This branch allows edits to all of the fields on acpl 1 except owning_lib and deleted: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp2023314_acpl_1_light_touch / working/user/jboyer/lp2023314_acpl_1_light_touch

Note that in addition to changing the protection level and type the upgrade script ensures that location 1 is owned by the top of the org tree.

[Susan Morrison (smorrison425)]

Testing for bug squashing week, I was able to edit all fields except for the owning library (results in an "update failed" message) and the "Is Deleted?" field (grayed out). Confirmed all other edits carried through as expected.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

[Jason Boyer (jboyer)]

Pushed to main, rel_3_11, and rel_3_10. Thanks Galen and Susan!