review-tools.snap-review execstack check fails to detect binaries with executable stacks

[Alex Murray]

$ snap info review-tools
name: review-tools
summary: Review tools for snappy
publisher: Canonical✓
store-url: https://snapcraft.io/review-tools
contact: https://bugs.launchpad.net/review-tools/+filebug
license: unset
description: |
  This snap provides the snap-review command as well as well as other tools
  related to snap review processes. These tools are used by the Ubuntu store
  and can be used to verify your snap before upload.
commands:
  - review-tools.base-declaration
  - review-tools.check-notices
  - review-tools.diffsquash
  - review-tools.fetch-usn-db
  - review-tools.rock-check-notices
  - review-tools.rock-updates-available
  - review-tools.snap-declaration
  - review-tools.snap-review
  - review-tools.store-query
  - review-tools.swift
  - review-tools.unpack-package
  - review-tools.updates-available
snap-id: 4Zx8o1ub19ibqNwTQbBHzUgT9zM0TLGs
tracking: latest/edge
refresh-date: 4 days ago, at 11:51 ACST
channels:
  latest/stable: 0.48+20230302-0425UTC 2023-03-08 (3098) 40MB -
  latest/candidate: 0.48+20230302-0425UTC 2023-03-08 (3098) 40MB -
  latest/beta: 0.48+20230329-0636UTC-24-ge8c9 2023-05-03 (3211) 40MB -
  latest/edge: 0.48+20230530-0510UTC-6-g09078 2023-06-06 (3261) 39MB -
installed: 0.48+20230530-0510UTC-6-g09078 (3255) 39MB -

$ review-tools.snap-review ./tests/test-execstack_0_amd64.snap
./tests/test-execstack_0_amd64.snap: pass

# this should fail since there is 1 file inside the snap with an executable stack

ProblemType: Bug
DistroRelease: Ubuntu 23.04
ProcVersionSignature: Ubuntu 6.2.0-20.20-generic 6.2.6
Uname: Linux 6.2.0-20-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.26.1-0ubuntu2
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Tue Jun 6 16:33:56 2023
InstallationDate: Installed on 2021-08-03 (672 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Alpha amd64 (20210802)
Snap: review-tools 0.48+20230530-0510UTC-6-g09078 (latest/edge)
SnapChanges: no changes found
SnapConnections:
 Interface Plug Slot Notes
 home review-tools:home :home manual
 mount-observe review-tools:mount-observe - -
 network review-tools:network :network -
SnapSource: review-tools
UpgradeStatus: Upgraded to lunar on 2023-01-27 (129 days ago)