[ml2/ovn] Binding_host_id shouldn't be set when a port is down

[Ihtisham ul Haq]

Currently e.g if you shelve an instance, the port for it is set to DOWN but the `binding_host_id` still exist for that port. And with sync to OVN Northbound `Logical_Switch_Port` table it is populated to `options:requested_chassis`. Which shouldn't be the case.

That also lead to northd throwing out these warnings, if that chassis got removed in the mean time:

```
northd|WARN|Unknown chassis '<chassis>' set in options:requested-chassis on LSP '<uuid>'
```

neutron version: stable/yoga

[yatin (yatinkarel)]

Thanks Ihtisham for the bug report, Just to have more context.

- Is the issue specific to instance shelve, or any other operations impacted?
- Apart from the warnings seen no other issue observed?
- "With the sync to OVN Northbound" you mean running neutron-ovn-db-sync-util?

If it's specific to nova shelve, shouldn't it be fixed in nova? or you mean issue is seen only with DB sync?

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello Ihtisham:

I've tested the "server shelve" and "server unshelve" commands with ML2/OVN. I can't reproduce the problem you are describing. I've confirmed several times the following facts:
* When the server is shelved:
** The LSP.options.requested-chassis is set to "".
** The Port Binding chassis is removed and the PB.options.requested-chassis is set to "".
** The Neutron port binding_host_id is cleared.

* When the server is unshelved:
** The LSP.options.requested-chassis receives the chassis ID.
** The Port Binding chassis set and the PB.options.requested-chassis receives the chassis ID.
** The Neutron port binding_host_id receives the host name.

What version are you using?

Regards.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]