Patch and re-enable main.derived_condition_pushdown test

Bug #2020696 reported by Dan Lenski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mysql-8.0 (Ubuntu)
Triaged
Low
Unassigned

Bug Description

The upstream MTR test `main.derived_condition_pushdown` was disabled in 8.0.33-0ubuntu2: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/8.0.33-0ubuntu2

The reason this test was failing was due to hardcoded timestamps in the upstream source, with the erroneous assumption that `2023-05-06` would always be "in the future". 🤦🏻‍♂️

I submitted a PR to remove the use of hardcoded timestamps in the test (BSD-licensed): https://github.com/mysql/mysql-server/pull/469

I also let the Debian packagers know about this fix: https://salsa.debian.org/mariadb-team/mysql/-/merge_requests/67#note_400519

Revision history for this message
Paride Legovini (paride) wrote :

Hello and thanks for this bug report. Looks like your upstream PR didn't land yet. Given that this doesn't look urgent, I think we should drop the "disable test" changes [1] once your PR lands. This way we'll be able to include your fix as a clean cherry-pick, which makes maintenance easier.

Could you please add a comment to this bug report once your fix lands? Thanks!

[1] https://launchpadlibrarian.net/665320975/mysql-8.0_8.0.33-0ubuntu1_8.0.33-0ubuntu2.diff.gz

Changed in mysql-8.0 (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

From the linked PR, it is unclear to me if the change was already merged upstream. I dropped a comment in the closed PR.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Reply to Athos' comment in the upstream PR:

@athos-ribeiro, it appears not. Apparently an "alternative fix" was applied internal to Oracle/MySQL… but, as I quickly pointed out, that "fix" does not actually fix the problem. 🤦‍♂️

It looks like the bug is still applicable.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.